#53015 closed defect (fixed)
octave-octclip, octave-octproj: missing patch file
Reported by: | Schamschula (Marius Schamschula) | Owned by: | MarcusCalhoun-Lopez (Marcus Calhoun-Lopez) |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | ports | Version: | 2.3.5 |
Keywords: | Cc: | ||
Port: | octave-octclip octave-octproj |
Description
octave-octclip and octave-octproj ask for patch-flags.diff, however this file was not uploaded along with the octave 4.2.0 update:
See https://github.com/macports/macports-ports/commit/5c63c9706d260f6a6557b110bb7608f0d92287bf
Attachments (2)
Change History (9)
comment:1 Changed 2 years ago by MarcusCalhoun-Lopez (Marcus Calhoun-Lopez)
Resolution: | → fixed |
---|---|
Status: | new → closed |
comment:3 Changed 2 years ago by Schamschula (Marius Schamschula)
Unfortunately, the patch file results in a broken build. Both octave-octclip and octave-octproj fail to build with an error like
In file included from /opt/local/include/octave-4.2.0/octave/Array.h:37: /opt/local/include/octave-4.2.0/octave/dim-vector.h:205:21: warning: variadic templates are a C++11 extension [-Wc++11-extensions] template <typename... Ints> ^ /opt/local/include/octave-4.2.0/octave/dim-vector.h:209:10: error: no member named 'initializer_list' in namespace 'std' std::initializer_list<octave_idx_type> all_lengths = {r, c, lengths...}; ~~~~~^ /opt/local/include/octave-4.2.0/octave/dim-vector.h:209:27: error: unexpected type name 'octave_idx_type': expected expression std::initializer_list<octave_idx_type> all_lengths = {r, c, lengths...}; ^ /opt/local/include/octave-4.2.0/octave/dim-vector.h:209:44: error: use of undeclared identifier 'all_lengths' std::initializer_list<octave_idx_type> all_lengths = {r, c, lengths...}; ^ /opt/local/include/octave-4.2.0/octave/dim-vector.h:209:58: error: expected expression std::initializer_list<octave_idx_type> all_lengths = {r, c, lengths...}; ^ /opt/local/include/octave-4.2.0/octave/dim-vector.h:210:33: warning: range-based for loop is a C++11 extension [-Wc++11-extensions] for (const octave_idx_type l: all_lengths) ^ /opt/local/include/octave-4.2.0/octave/dim-vector.h:210:35: error: use of undeclared identifier 'all_lengths' for (const octave_idx_type l: all_lengths) ^ /opt/local/include/octave-4.2.0/octave/dim-vector.h:212:12: error: use of undeclared identifier 'all_lengths' rep -= all_lengths.size (); ^
For some reason configure.cxxflags-append -std=c++11
in octave-1.0.tcl seems to be ignored. I modified patch-flags.diff
to add CXXFLAGS+=-std=c++11
, resulting in a clean build.
However, I now got a MacPorts destroot error:
Error: org.macports.destroot for port octave-octproj returned: xinstall: Cannot stat: /opt/local/var/macports/build/_Users_marius_Development_MacPorts_ports_math_octave-octproj/octave-octproj/work/octproj/octproj-1.1.5.tar.gz, No such file or directory
On further investigation, I got octproj-1.1.5-x86_64-apple-darwin16.x.x-api-v51.tar.gz
instead. I manually renamed this file to octproj-1.1.5.tar.gz
and got it to install.
comment:4 Changed 2 years ago by MarcusCalhoun-Lopez (Marcus Calhoun-Lopez)
This is very strange.
I have not encountered either of these errors.
Would it be too much to ask to post the main.log files for the two failed builds?
Changed 2 years ago by Schamschula (Marius Schamschula)
Attachment: | octave-octclip-main.log.gz added |
---|
Changed 2 years ago by Schamschula (Marius Schamschula)
Attachment: | octave-octproj-main.log.gz added |
---|
comment:5 Changed 2 years ago by Schamschula (Marius Schamschula)
Here are the Sierra logs for octave-octclip and octave-octproj.
comment:6 Changed 2 years ago by MarcusCalhoun-Lopez (Marcus Calhoun-Lopez)
Based on the output, I believe you may be using an older version of octave.tcl
(perhaps in /Users/marius/Development/MacPorts/ports/_resources/port1.0/group/octave-1.0.tcl).
In your log files, LC_CTYPE='C'
, but this was removed in 9ea1455/macports-ports.
Similarly, LAPACK_LIBS
is no longer set explicitly.
comment:7 Changed 2 years ago by Schamschula (Marius Schamschula)
Good catch!
I had this in my local tree on one machine (unfortunately the one I use to do most test builds).
In 9ea1455/macports-ports: