Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#53079 closed defect (fixed)

cctools @895 does not build on a PPC running leopard

Reported by: josephsacco Owned by: jeremyhu (Jeremy Huddleston Sequoia)
Priority: Normal Milestone:
Component: ports Version:
Keywords: PPC leopard Cc: jeremyhu@…
Port: cctools

Description

cctools @895 does not build on a PPC running OS X 10.5.8 due to a typo in libstuff/ofile.c

$ cat cctools-895-ofile.patch
--- libstuff/ofile.c-	2016-12-16 11:53:10.000000000 -0500
+++ libstuff/ofile.c	2016-12-16 11:53:41.000000000 -0500
@@ -3423,7 +3423,7 @@
 	    if(size - offset > sizeof(uint32_t)){
 		memcpy(&magic, addr + offset, sizeof(uint32_t));
 #ifdef __BIG_ENDIAN__
-		if(magic == FAT_MAGIC || (magic == FAT_MAGIC_64)
+		if(magic == FAT_MAGIC || (magic == FAT_MAGIC_64))
 #endif /* __BIG_ENDIAN__ */
 #ifdef __LITTLE_ENDIAN__
 		if(magic == SWAP_INT(FAT_MAGIC) ||

A patch file containing the above patch is attached.

-Joseph

Attachments (1)

cctools-895-ofile.patch (454 bytes) - added by josephsacco 7 years ago.
patch file for libstudd/ofile.c

Download all attachments as: .zip

Change History (3)

Changed 7 years ago by josephsacco

Attachment: cctools-895-ofile.patch added

patch file for libstudd/ofile.c

comment:1 Changed 7 years ago by jeremyhu (Jeremy Huddleston Sequoia)

Owner: set to jeremyhu
Resolution: fixed
Status: newclosed

In 57f6eba/macports-ports:

cctools: Address ppc build failure

Fixes #53079
<rdar://problem/29708696>

Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@…>

comment:2 Changed 7 years ago by jeremyhu (Jeremy Huddleston Sequoia)

In 250e2336/macports-ports:

cctools: Address ppc build failure

Fixes #53079
<rdar://problem/29708696>

Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@…>

Note: See TracTickets for help on using tickets.