#53382 closed enhancement (fixed)
webp pull in a lot of Xorg dependencies through freeglut
| Reported by: | F30 (Felix Dreissig) | Owned by: | ryandesign (Ryan Carsten Schmidt) |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | |
| Keywords: | haspatch | Cc: | wimmez (Willem), ctreleaven (Craig Treleaven) |
| Port: | webp |
Description
Since nobody else appears to have opened an issue so far, I am reporting this based on the GitHub comments from [0fb0ecb1b8219de69274da728378f31aa6bd24d8/macports-ports]:
The change added a mandatory dependency on freeglut for webp because of #53358. However, freeglut depends on a lot of Xorg ports, which were not required before.
In particular, this breaks imagemagick's -x11 variant as imagemagick depends on webp.
It would be nice to find another way to make the webp port deterministic.
Attachments (2)
Change History (15)
comment:1 Changed 7 years ago by F30 (Felix Dreissig)
| Cc: | F30 added |
|---|
comment:2 Changed 7 years ago by mf2k (Frank Schima)
| Cc: | F30 removed |
|---|---|
| Keywords: | xorg x11 webp freeglut imagemagick removed |
| Owner: | set to ryandesign |
| Status: | new → assigned |
| Type: | defect → enhancement |
comment:3 Changed 7 years ago by ryandesign (Ryan Carsten Schmidt)
I assume this change doesn't actually "break" anything, merely causes more dependencies to be pulled in than you would like. On the contrary, the reason why I made the change was to try to fix #53358.
I'm happy to remove the freeglut dependency again, so long as webp does not attempt to link with freeglut if it happens to already be installed (which is what was happening before my change) and so long as #53358 does not become unfixed in the process.
comment:4 Changed 7 years ago by F30 (Felix Dreissig)
So I'm not really into OpenGL and only have a rough idea of what's going on here, but digging through webp's configure I found the --with-glincludedir and --with-gllibdir options which specify where to look for GL. Could they help here?
Changed 7 years ago by jmroot (Joshua Root)
| Attachment: | Portfile.diff added |
|---|
Changed 7 years ago by jmroot (Joshua Root)
| Attachment: | configure.patch added |
|---|
comment:5 Changed 7 years ago by jmroot (Joshua Root)
I've attached the patches I'm using locally. (I previously sent the configure one via email.)
comment:6 Changed 7 years ago by wimmez (Willem)
| Cc: | wimmez added |
|---|
comment:7 follow-up: 8 Changed 7 years ago by wimmez (Willem)
Maybe the portfile could be modified to support an -x11 option which excludes dependencies on MESA and freeglut?
comment:8 Changed 7 years ago by jmroot (Joshua Root)
| Keywords: | haspatch added |
|---|
Replying to wimmez:
Maybe the portfile could be modified to support an
-x11option which excludes dependencies on MESA and freeglut?
There isn't any advantage to having a variant rather than just not using those ports all the time.
comment:9 Changed 7 years ago by ryandesign (Ryan Carsten Schmidt)
| Status: | assigned → accepted |
|---|
I'm combining this fix with updating the port to 0.6.0, which comes with a new library version which requires rebuilding all ports that link with it; I'm testing that before committing.
comment:10 Changed 7 years ago by ctreleaven (Craig Treleaven)
| Cc: | ctreleaven added |
|---|
comment:11 Changed 7 years ago by ryandesign (Ryan Carsten Schmidt)
| Resolution: | → fixed |
|---|---|
| Status: | accepted → closed |
In the future, please Cc the port maintainers (
port info --maintainers webp), if any. As reporter, you do not need to Cc yourself.