port reclaim reports .turd_MacPorts file as unnused distfile

[neverpanic (Clemens Lang)]

MacPorts .pkg installers are created using port pkg MacPorts from the MacPorts port. MacPorts strips empty directories before packaging after destroot. We specify destroot.keepdirs in the MacPorts port to avoid this, but this directive creates .turd_MacPorts files to make these directories non-empty.

This also happens for $prefix/var/macports/distfiles, which is now scanned by port reclaim when run. port reclaim does not know about the .turd_MacPorts file, considers it to be an unused distfile and suggests deleting it. While not a problem per-se, this is unexpected for users.

[neverpanic (Clemens Lang)]

In b0c0957/macports-base:

reclaim: Ignore .turd_MacPorts files

Ignore .turd_MacPorts files in reclaim to avoid confusing users when
reclaim claims the file is an unused distfile even though it was put
there by the MacPorts installer.

Closes: #53436

[neverpanic (Clemens Lang)]

In 8ee43f7/macports-base:

reclaim tests: Remove constraints, add turd test

Remove interactivity and root constraints from reclaim test by mocking
everything that would require these constraints.

Add a test to verify that .turd_MacPorts files are kept by reclaim.

See: #53436

[neverpanic (Clemens Lang)]

Second commit is the backport to release-2.4.

[Clemens Lang <neverpanic@…>]

In 8f8bead/macports-base:

Changelog: Add b0c0957

Add a changelog entry for a bug fixed in reclaim.

See: #53436