port diagnose and fish shell

[bestlem]

I use a non POSIX shell - fish

When I run port diagnose it gives

Warning: your $PATH environment variable does not currently include, /opt/local/bin, which is where port is located.  Would you like to add /opt/local/bin to your $PATH variable now? [Y/N]

Which has two issues

• /opt/local/bin is on my path and so there is not an error.
• Second issue is that it cannot add to my path so the question is meaningless

[mf2k (Frank Schima)]

In the future, please use WikiFormatting.

[jmroot (Joshua Root)]

In 17c70c9/macports-base:

Port diagnose PATH check improvements

Get shell from dscl instead of assuming bash. Don't try to check the
value of PATH with shells we don't know about. The code to add our dirs
to PATH only works with bash, so don't offer to do it with other
shells. Use the interactive questions API instead of reimplementing it.

Fixes: #53473