libarchive @3.3.1: error: possibly undefined macro: AC_MSG_FAILURE

[tideofwords]

I'm running:

• Mac OS Sierra Version 10.12.3 (16D32)
• XCode Version 8.3 (8E162)

I tried to install kdenlive ("sudo port install kdenlive"). It gave me the following error message:

--->  Applying patches to libarchive
Error: Failed to patch libarchive: command execution failed
Error: See /opt/local/var/macports/logs/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_archivers_libarchive/libarchive/main.log for details.
Error: Follow https://guide.macports.org/#project.tickets to report a bug.
Error: Processing of port kdenlive failed

I'm new to MacPorts, and this is quite a bit more complicated than any install I've ever done -- please help!

[tideofwords]

main.log

[deszoeke (Simon de Szoeke)]

This appears to be a problem with the dependency libarchive. For me libarchive-3.3.1_1.darwin_16.x86_64 fails to patch with

sudo port upgrade outdated

after updating to Xcode 8.3 8E162 (MacOS 10.12.4).

From my log, something in autoconf seems to break:

168 :debug:patch Executing proc-post-org.macports.patch-patch-0
169 :debug:patch system -W /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_archivers_libarchive/libarchive/work/libarchive-3.3.1: build/autogen.sh
170 :info:patch + aclocal -I build/autoconf
171 :info:patch + case `uname` in
172 :info:patch ++ uname
173 :info:patch + glibtoolize --automake -c
174 :info:patch + autoconf
175 :info:patch configure.ac:136: error: possibly undefined macro: AC_MSG_FAILURE
176 :info:patch       If this token and others are legitimate, please use m4_pattern_allow.
177 :info:patch       See the Autoconf documentation.
178 :info:patch configure.ac:310: error: possibly undefined macro: AC_CHECK_LIB
179 :info:patch Command failed: build/autogen.sh
180 :info:patch Exit code: 1
181 :error:patch Failed to patch libarchive: command execution failed
182 :debug:patch Error code: NONE
183 :debug:patch Backtrace: command execution failed
184 :debug:patch     while executing
185 :debug:patch "$post $targetname"
186 :error:patch See /opt/local/var/macports/logs/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_archivers_libarchive/libarchive/main.log for details.
187 version:1

Similarly in @tideofwords's log, some autoconf macros appear to be missing. Perhaps that's relevant.

Replying to tideofwords:

I'm running:

• Mac OS Sierra Version 10.12.3 (16D32)
• XCode Version 8.3 (8E162)

I tried to install kdenlive ("sudo port install kdenlive"). It gave me the following error message:

--->  Applying patches to libarchive
Error: Failed to patch libarchive: command execution failed
Error: See /opt/local/var/macports/logs/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_archivers_libarchive/libarchive/main.log for details.
Error: Follow https://guide.macports.org/#project.tickets to report a bug.
Error: Processing of port kdenlive failed

I'm new to MacPorts, and this is quite a bit more complicated than any install I've ever done -- please help!

[deszoeke (Simon de Szoeke)]

Based on a suggestion at ​https://github.com/sleuthkit/sleuthkit/issues/263 running

sudo port install autoconf automake libtool pkgconfig
sudo port clean libarchive

first, then continuing my upgrade/installation made it work.

[ryandesign (Ryan Carsten Schmidt)]

This seems to be fallout from fixing #53712.

[michaelld (Michael Dickens)]

Maybe it's because I used "depends_build" instead of "depends_lib"? I can't imagine that pkgconfig makes any difference, but maybe so? Otherwise the other 3 dependencies are included for "build" (even though they are used in post-patch).

[ryandesign (Ryan Carsten Schmidt)]

Has duplicate #53897 which says pkgconfig is needed.

depends_build is correct for autoconf, automake, libtool and pkgconfig. depends_lib would not be correct as those are not used at runtime, only at build time.

It is not correct to call programs installed by dependencies in a post-patch block, because you cannot guarantee that the programs have been installed by then; that's only guaranteed by the start of the configure phase.

[Mihai Moldovan <ionic@…>]

In c8485fe8e579277abb8024c6fcb480be241ba8df/macports-ports:

archivers/libarchive: use automatic autoreconf, add pkgconfig dependency.

Fixes: #53889.