ntpsec @0.9.7: error: POSIX clock_settime(2) is required

[ryandesign (Ryan Carsten Schmidt)]

ntpsec builds on Sierra but fails to build on El Capitan and earlier.

​https://build.macports.org/builders/ports-10.11_x86_64-builder/builds/22564

../../libntp/clockwork.c:145:2: error: POSIX clock_gettime(2) is required
#error POSIX clock_gettime(2) is required
 ^
../../libntp/clockwork.c:132:19: warning: unused parameter 'tvs' [-Wunused-parameter]
        struct timespec *tvs
                         ^
1 warning and 1 error generated.

(clock_gettime was introduced in Sierra.)

[danielluke (Daniel J. Luke)]

This really should be addressed upstream (but I suspect they'll be hesitant to do anything about it, since part of the point of the ntpsec project is to remove backwards compatibility that adds complexity and could hide security issues).

[lbschenkel (Leonardo Brondani Schenkel)]

Reported to upstream: ​https://gitlab.com/NTPsec/ntpsec/issues/261

[lbschenkel (Leonardo Brondani Schenkel)]

ESR has replied saying that there is a fallback already and it should build: ​https://gitlab.com/NTPsec/ntpsec/issues/261#note_27103442

Unfortunately I don't have access to a pre-Sierra installation in order to diagnose why the existing fallback is not triggering. Anybody up for the task?

[ryandesign (Ryan Carsten Schmidt)]

main.log from my 10.8 test vm

[ryandesign (Ryan Carsten Schmidt)]

config.log from my 10.8 test vm

[ryandesign (Ryan Carsten Schmidt)]

I've attached log files from my 10.8 test VM in case that's helpful. ESR should be able to reproduce the issue by trying to build ntpsec 0.9.6 on any Mac with OS X 10.11 or earlier.

[ryandesign (Ryan Carsten Schmidt)]

The error message in 0.9.6 was wrong; the error message was corrected in 0.9.7. It's clock_settime that's missing, not clock_gettime.

[lbschenkel (Leonardo Brondani Schenkel)]

Closing, upstream stated that they won't support old macOS versions below 10.12.

[ryandesign (Ryan Carsten Schmidt)]

Then please modify the port to error out early with a friendlier error message. Something like:

pre-fetch {
    if {${os.platform} eq "darwin" && ${os.major} < 16} {
        ui_error "${name} @${version} requires macOS 10.12 or greater."
        return -code error "incompatible macOS version"
    }
}

[lbschenkel (Leonardo Brondani Schenkel)]

In 2afd39717cf554afa8b43761843f49268ec54c34/macports-ports:

ntpsec: prevent installation on macOS < 10.12

Upstream does not support versions of macOS older than 10.12:
​https://gitlab.com/NTPsec/ntpsec/issues/261

Closes: #53928

[lbschenkel (Leonardo Brondani Schenkel)]

Thanks for the snippet. I have included it in the Portfile.