Changes between Version 1 and Version 2 of Ticket #53974, comment 19


Ignore:
Timestamp:
Jun 5, 2017, 7:25:37 AM (7 years ago)
Author:
slewsys (Andrew L. Moore)
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #53974, comment 19

    v1 v2  
    22> The patch above points to the right direction, but doesn't seem to be entirely correct. Here's a revised patch written by Akira Kakuto. Can you please test that one?
    33
    4 Akira's patch is correct.  I was thinking that separately allocating colordat isn't necessary, but actually it is.  The declaration colordat[2] was evidently a hack to get avoid that allocation, but clang won't let you get away with it.  So changing colordat to a single pointer and separately allocating/freeing it is correct.  Thanks to Akira Kakuto for clear thinking :)
     4Akira's patch is correct.  I was thinking that separately allocating colordat isn't necessary, but actually it is.  The declaration colordat[2] was evidently a hack to avoid that allocation, but clang won't let you get away with it.  So changing colordat to a single pointer and separately allocating/freeing it is correct.  Thanks to Akira Kakuto for clear thinking :)