Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#54054 closed enhancement (duplicate)

grc: Update to version 1.11 and add python 3 variants

Reported by: 1-61803 Owned by:
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc:
Port: grc

Attachments (2)

Portfile (2.6 KB) - added by 1-61803 7 years ago.
rewritten with portgroup python
Portfile-grc.diff (3.5 KB) - added by 1-61803 7 years ago.
rewritten with portgroup python

Download all attachments as: .zip

Change History (7)

comment:1 Changed 7 years ago by ryandesign (Ryan Carsten Schmidt)

You should use depends_lib-append in variants, rather than depends_lib, so that you don't overwrite dependencies that might be defined at the top level of the port.

There should be a python36 variant to go with the python34 and python35 variants, and it should be the default (PortfileRecipes#default_variants)

The python portgroup might be able to help you write your python variants more succinctly.

Mind your whitespace: the post-destroot block is indented too far.

I notice you removed supported_archs noarch. Just wanted to make sure that was intentional and that this version of grc now does install architecture-specific files.

comment:2 Changed 7 years ago by mf2k (Frank Schima)

Summary: grc @1.11grc: Update to version 1.11 and add python 3 variants
Type: updateenhancement

comment:3 in reply to:  1 Changed 7 years ago by 1-61803

Replying to ryandesign:

I'll emend depends_lib-append and the post-destroot block indention.

Re supported_archs noarch, I assumed it was a remnant of some old style, since the guide states "If this option is not set, it is assumed that the port can build for all archs.". I'll readd it if need be.

Without default_variants it builds with 3.6, should I use the canonical recipe you pointed me at? I tested all 3 versions without problems.

I couldn't find a way to use the portgroup python as I intended in the first place, nor a similar portfile that just does reinplace/xinstall with variants. Maybe you can name an example?

Changed 7 years ago by 1-61803

Attachment: Portfile added

rewritten with portgroup python

Changed 7 years ago by 1-61803

Attachment: Portfile-grc.diff added

rewritten with portgroup python

comment:4 Changed 7 years ago by mf2k (Frank Schima)

Resolution: duplicate
Status: newclosed

Duplicate of #54256 which has newer patchfile.

comment:5 Changed 7 years ago by 1-61803

For the life of me, I cannot see what holds you from committing #54256, or at least, commenting on that ticket, in order to correct the portfile, if necessary.

Note: See TracTickets for help on using tickets.