Opened 9 years ago
Last modified 2 years ago
#54176 assigned enhancement
boost assumes libc++ is only used by clang
| Reported by: | RJVB (René Bertin) | Owned by: | michaelld (Michael Dickens) |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | |
| Keywords: | haspatch | Cc: | michaelld (Michael Dickens), cooljeanius (Eric Gallager) |
| Port: | boost |
Description
While testing the idea of using libc++ while building C++ code with G++ I ran into (amost) exactly the errors shown here : http://stackoverflow.com/questions/41050942/clang-modules-interaction-with-std-iterator-and-boost-move-iterator-hpp/43983903
In this case the errors were not caused by libc++ but by the simple fact that in a few locations, boost assumes that libc++ is only used with clang.
After fixing those presumptions with the attached patch I was able to build both boost and digiKam5 (which uses Boost and is a good test for any C++ compiler).
Attachments (1)
Change History (8)
Changed 9 years ago by RJVB (René Bertin)
| Attachment: | patch-libcpp-everywhere.diff added |
|---|
comment:1 Changed 9 years ago by mf2k (Frank Schima)
| Cc: | ryandesign removed |
|---|---|
| Owner: | set to ryandesign |
| Status: | new → assigned |
comment:2 Changed 9 years ago by neverpanic (Clemens Lang)
comment:3 Changed 9 years ago by RJVB (René Bertin)
it probably should, but in that case we should probably first update the port
comment:4 Changed 6 years ago by ryandesign (Ryan Carsten Schmidt)
| Owner: | changed from ryandesign to michaelld |
|---|
No, it should be reported to the developers of boost first (if it's still a problem). They are more familiar with their code than we are and are better able to judge what changes are appropriate. If they agree and fix it and release a new version then we can update to that version or we can cherry-pick their commit into a patch until a new version is released.
comment:5 Changed 5 years ago by kencu (Ken)
| Cc: | kencu added |
|---|
comment:6 Changed 5 years ago by kencu (Ken)
| Cc: | kencu removed |
|---|
comment:7 Changed 2 years ago by cooljeanius (Eric Gallager)
| Cc: | cooljeanius added |
|---|

I think this should go to boost upstream.