py27-cryptography @2.0: error: -Werror=sign-conversion: No option -Wsign-conversion

[ballapete (Peter "Pete" Dyballa)]

building '_openssl' extension
creating build/temp.macosx-10.4-ppc-2.7/build
creating build/temp.macosx-10.4-ppc-2.7/build/temp.macosx-10.4-ppc-2.7
/opt/local/bin/gcc-apple-4.2 -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -arch ppc -I/opt/local/Library/Frameworks/Python.framework/Versions/2.7/include/python2.7 -c build/temp.macosx-10.4-ppc-2.7/_openssl.c -o build/temp.macosx-10.4-ppc-2.7/build/temp.macosx-10.4-ppc-2.7/_openssl.o -Wconversion -Wno-error=sign-conversion
cc1: error: -Werror=sign-conversion: No option -Wsign-conversion
error: command '/opt/local/bin/gcc-apple-4.2' failed with exit status 1
Command failed:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_lil.fr.rsync.macports.org_release_tarballs_ports_python_py-cryptography/py27-cryptography/work/cryptography-2.0" && /opt/local/Library/Frameworks/Python.framework/Versions/2.7/bin/python2.7 setup.py --no-user-cfg build 
Exit code: 1

The faulty setting is obviously in

./src/_cffi_src/build_openssl.py:        return ["-Wconversion", "-Wno-error=sign-conversion"]

in a code block

    if platform != "win32":
        return ["-Wconversion", "-Wno-error=sign-conversion"]
    else:
        return []

Removing the second argument produces some unnecessary output

build/temp.macosx-10.4-ppc-2.7/_openssl.c: In function 'Cryptography_pem_password_cb':
build/temp.macosx-10.4-ppc-2.7/_openssl.c:2568: warning: passing argument 3 of 'memcpy' as unsigned due to prototype
build/temp.macosx-10.4-ppc-2.7/_openssl.c: In function '_cffi_d_SSL_CTX_clear_options':
build/temp.macosx-10.4-ppc-2.7/_openssl.c:47473: warning: passing argument 3 of 'SSL_CTX_ctrl' as signed due to prototype
build/temp.macosx-10.4-ppc-2.7/_openssl.c: In function '_cffi_f_SSL_CTX_clear_options':
build/temp.macosx-10.4-ppc-2.7/_openssl.c:47506: warning: passing argument 3 of 'SSL_CTX_ctrl' as signed due to prototype
build/temp.macosx-10.4-ppc-2.7/_openssl.c: In function '_cffi_d_SSL_CTX_set_mode':
build/temp.macosx-10.4-ppc-2.7/_openssl.c:49314: warning: passing argument 3 of 'SSL_CTX_ctrl' as signed due to prototype
build/temp.macosx-10.4-ppc-2.7/_openssl.c: In function '_cffi_f_SSL_CTX_set_mode':
build/temp.macosx-10.4-ppc-2.7/_openssl.c:49347: warning: passing argument 3 of 'SSL_CTX_ctrl' as signed due to prototype
build/temp.macosx-10.4-ppc-2.7/_openssl.c: In function '_cffi_d_SSL_CTX_set_options':
build/temp.macosx-10.4-ppc-2.7/_openssl.c:49478: warning: passing argument 3 of 'SSL_CTX_ctrl' as signed due to prototype
build/temp.macosx-10.4-ppc-2.7/_openssl.c: In function '_cffi_f_SSL_CTX_set_options':
build/temp.macosx-10.4-ppc-2.7/_openssl.c:49511: warning: passing argument 3 of 'SSL_CTX_ctrl' as signed due to prototype
build/temp.macosx-10.4-ppc-2.7/_openssl.c: In function '_cffi_d_SSL_CTX_set_session_cache_mode':
build/temp.macosx-10.4-ppc-2.7/_openssl.c:49524: warning: passing argument 3 of 'SSL_CTX_ctrl' as signed due to prototype
build/temp.macosx-10.4-ppc-2.7/_openssl.c: In function '_cffi_f_SSL_CTX_set_session_cache_mode':
build/temp.macosx-10.4-ppc-2.7/_openssl.c:49557: warning: passing argument 3 of 'SSL_CTX_ctrl' as signed due to prototype
build/temp.macosx-10.4-ppc-2.7/_openssl.c: In function '_cffi_d_SSL_set_mode':
build/temp.macosx-10.4-ppc-2.7/_openssl.c:53391: warning: passing argument 3 of 'SSL_ctrl' as signed due to prototype
build/temp.macosx-10.4-ppc-2.7/_openssl.c: In function '_cffi_f_SSL_set_mode':
build/temp.macosx-10.4-ppc-2.7/_openssl.c:53424: warning: passing argument 3 of 'SSL_ctrl' as signed due to prototype
build/temp.macosx-10.4-ppc-2.7/_openssl.c: In function '_cffi_d_SSL_set_options':
build/temp.macosx-10.4-ppc-2.7/_openssl.c:53437: warning: passing argument 3 of 'SSL_ctrl' as signed due to prototype
build/temp.macosx-10.4-ppc-2.7/_openssl.c: In function '_cffi_f_SSL_set_options':
build/temp.macosx-10.4-ppc-2.7/_openssl.c:53470: warning: passing argument 3 of 'SSL_ctrl' as signed due to prototype

but lets the port build.

[ballapete (Peter "Pete" Dyballa)]

proposed patch file for Tiger

[ballapete (Peter "Pete" Dyballa)]

The same error applies to py27-cryptography @ 2.0.3_0.

[ryandesign (Ryan Carsten Schmidt)]

Has duplicate #54753.

[ryandesign (Ryan Carsten Schmidt)]

Has duplicate #55079.

[kencu (Ken)]

For a data point, it builds for me on 10.6.8 without modification:

  py27-cryptography @2.1.4_0 (active) platform='darwin 10' archs='x86_64' date='2017-12-10T20:27:12-0800'

I have my default compiler set to clang-3.9, and I'm set up using LibcxxOnOlderSystems.

[ballapete (Peter "Pete" Dyballa)]

Right now Tiger does not need that package, Python 2.7 is gone, and we're now at version 3.3.2. Nevertheless, the modern port builds with just a few complaints about values set or used in CPython.

It can be closed.

[kencu (Ken)]

Thanks!