#54542 closed defect (duplicate)

gtk3 @3.22.17: error: expected '>'

Reported by: Gord-Butler Owned by: dbevans (David B. Evans)
Priority: Normal Milestone:
Component: ports Version: 2.4.1
Keywords: mavericks Cc: jjstickel (Jonathan Stickel), poetnerd (Bill Cattey), mfuhrer
Port: gtk3

Description

Having trouble upgrading gtk3 on Mavericks. The upgrade quits at the build stage. Log file included.

Attachments (1)

main2.log (985.6 KB) - added by Gord-Butler 17 months ago.
Log file of port build

Download all attachments as: .zip

Change History (12)

Changed 17 months ago by Gord-Butler

Attachment: main2.log added

Log file of port build

comment:1 Changed 17 months ago by ryandesign (Ryan Schmidt)

Cc: dbevans removed
Keywords: gtk3 10.9 removed
Owner: set to dbevans
Status: newassigned
Summary: gtk3 3.22.17 fails to build on Mavericks 10.9.5gtk3 @3.22.17: error: expected '>'

What versions of Xcode, command line tools, and clang do you have installed?

Looks similar to #54518.

comment:2 Changed 16 months ago by kencu (Ken)

I just worked through this on 10.8. It only happens with the +quartz build. I don't have patches as yet, but here's what I did to build it.

fixing gtk3 +quartz:

in work/gtk+-3.22.17/gtk:

in gtkfilefilterprivate.h
and in gtkfilefilter.c

Change
NSArray<NSString *> *
-to- NSArray *

============
in work/gtk+-3.22.17/gtk

in  gtkfilechoosernativequartz.c

Make the following replacements:

NSMutableArray<NSArray<NSString *> *> *
-to- NSMutableArray *

NSMutableArray<NSString *> *
-to- NSMutableArray *

NSArray<NSString *> *
-to- NSArray *

NSMutableArray<NSArray *>
-to- NSMutableArray

NSMutableArray<NSString *>
-to- NSMutableArray

comment:3 Changed 16 months ago by kencu (Ken)

See <https://github.com/GNOME/gtk/commits/master/gtk/gtkfilechoosernativequartz.c>

It's a new enhancement; perhaps upstream would agree to #ifdef some minor changes in to support older sdks. Otherwise, the changes I made took about 10 minutes to do, so it's an easy patch once I or someone gets around to it.

Last edited 16 months ago by kencu (Ken) (previous) (diff)

comment:4 Changed 16 months ago by jjstickel (Jonathan Stickel)

Cc: jjstickel added

comment:5 Changed 16 months ago by poetnerd (Bill Cattey)

Cc: poetnerd added

comment:6 Changed 16 months ago by poetnerd (Bill Cattey)

Hi Ken,

Thanks for moving this one forward. Your list of replacements is good, but can't be treated as an exact substitution because line 465 looks like this:

     data->filters = [NSMutableArray<NSArray<NSString *> *> arrayWithCapacity:n_filters];

We have to change that to:

     data->filters = [NSMutableArray arrayWithCapacity:n_filters];
Last edited 10 months ago by ryandesign (Ryan Schmidt) (previous) (diff)

comment:7 Changed 16 months ago by kencu (Ken)

Don't forget that a helpful patch has been made already to ease the pain :)

attachment:ticket:54518:gtk3_NSArray.patch

Last edited 10 months ago by ryandesign (Ryan Schmidt) (previous) (diff)

comment:8 in reply to:  7 Changed 16 months ago by jjstickel (Jonathan Stickel)

Replying to kencu:

Don't forget that a helpful patch has been made already to ease the pain :)

attachment:ticket:54518:gtk3_NSArray.patch

As reported in #54518, that patch works now with gtk3 @3.22.19_0+quartz.

Last edited 10 months ago by ryandesign (Ryan Schmidt) (previous) (diff)

comment:9 Changed 16 months ago by poetnerd (Bill Cattey)

Cool! Thanks!

comment:10 Changed 14 months ago by mfuhrer

Cc: mfuhrer added

comment:11 Changed 10 months ago by ryandesign (Ryan Schmidt)

Resolution: duplicate
Status: assignedclosed
Note: See TracTickets for help on using tickets.