#54600 closed update (fixed)
angband @4.0.5: update to 4.1.0
| Reported by: | l2dy (Zero King) | Owned by: | jfcaron3 |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | |
| Keywords: | haspatch maintainer | Cc: | |
| Port: | angband |
Description
Attachments (2)
Change History (8)
Changed 7 years ago by jfcaron3
| Attachment: | Portfile-angband.diff added |
|---|
comment:1 Changed 7 years ago by jfcaron3
I made a patch following the instructions on the Guide. I had to add a line about worksrcdir because the latest source archive doesn't untar into the expected ${name}-${version} folder, it untars into a folder called angband-master.
comment:2 Changed 7 years ago by raimue (Rainer Müller)
| Keywords: | haspatch maintainer added |
|---|
Changed 7 years ago by l2dy (Zero King)
| Attachment: | 0001-angband-update-to-4.1.0-use-the-right-compiler.patch added |
|---|
comment:3 Changed 7 years ago by l2dy (Zero King)
I added CC=${configure.cc} to use the right compiler, see wiki:UsingTheRightCompiler for details.
@jfcaron3, OK to commit?
comment:4 follow-up: 6 Changed 7 years ago by jfcaron3
Not sure why CC=${configure.cc} is necessary, even after reading the UsingTheRightCompiler page twice. My interpretation of the page is that MacPorts will automatically tell configure to use the XCode compiler, UNLESS you set the CC variable...
"For most ports, the default compiler chosen by MacPorts is the one that should be used"
Anyways, you probably know more about this than I do, so sure go ahead and commit.
comment:5 Changed 7 years ago by l2dy (Zero King)
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
comment:6 Changed 7 years ago by l2dy (Zero King)
Replying to jfcaron3:
Not sure why CC=${configure.cc} is necessary, even after reading the UsingTheRightCompiler page twice. My interpretation of the page is that MacPorts will automatically tell configure to use the XCode compiler, UNLESS you set the CC variable...
"For most ports, the default compiler chosen by MacPorts is the one that should be used"
Without CC=${configure.cc}, angband will build with its default compiler rather than the compiler chosen by MacPorts.
Portfile patch to update angband to 4.1.0.