Opened 9 years ago

Last modified 9 years ago

#54654 assigned defect

cdda_interface.h breaks C++ builds

Reported by: RJVB (René Bertin) Owned by: jeremyhu (Jeremy Huddleston Sequoia)
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch Cc:
Port: cdparanoia

Description

The cdda_interface.h header file from port:cdparanoia defines a struct with a member variable called private. That is not acceptable under C++ but can be fixed with a simple patch to the *installed* headerfile: 

reinplace "s|cdda_private_data_t \\*private;|cdda_private_data_t \\*private_data;|g" ${destroot}${prefix}/include/cdda_interface.h

Evidently one can also make this change throughout the code before building cdparanoia. I'm attaching a patch file from Debian which does that, as is (the 2 hunks for interface.c need fixing to apply after the current MacPorts patches).

Attachments (2)

03-gcc4.3.patch​ (18.3 KB) - added by RJVB (René Bertin) 9 years ago.
gcc4.3.patch​ (20.0 KB) - added by RichieB2B (Richie B2B) 6 years ago.
Cleaned up version

Download all attachments as: .zip

Change History (3)

Changed 9 years ago by RJVB (René Bertin)

Attachment: 03-gcc4.3.patch​ added

comment:1 Changed 9 years ago by mf2k (Frank Schima)

Cc: jeremyhu removed
Owner: set to jeremyhu
Status: new → assigned

Changed 6 years ago by RichieB2B (Richie B2B)

Attachment: gcc4.3.patch​ added

Cleaned up version

Note: See TracTickets for help on using tickets.