Opened 5 years ago

Closed 4 years ago

#54662 closed defect (fixed)

mc @4.8.19 +ncurses: build fails with ncurses 6

Reported by: philippetev (Philip Petev) Owned by: kurthindenburg (Kurt Hindenburg)
Priority: Normal Milestone:
Component: ports Version: 2.4.1
Keywords: haspatch Cc:
Port: mc

Description

The latest version 4.8.19 (the ncurses variant) can't be built against ncurses 6.x. The problem is solved upstream, but it seems the maintainer of that port hasn't seen it yet.

The solution: lib/tty/tty-ncurses.c should be patched against the latest upstream version of that file in order the variant to be built with ncurses 6.0 and later.
Obviously, that problem won't be present in the future versions.

For more info: https://github.com/MidnightCommander/mc/commits/master/lib/tty/tty-ncurses
Ticket 3697

Attachments (1)

patch_ncurses6x.diff (1.3 KB) - added by philippetev (Philip Petev) 5 years ago.
Patch for ncurses 6.x+

Download all attachments as: .zip

Change History (12)

comment:1 Changed 5 years ago by Schamschula (Marius Schamschula)

Priority: HighNormal

Please do not set priority!

comment:2 Changed 5 years ago by philippetev (Philip Petev)

If failed build is not High priority, then what it is?
I've already prepared the patch here:
https://mega.nz/#!xBdHlC5Q!1grv9tZexRCFQnLfYxvPMI8YGw9AQD4phs4lORrq2ZI
All it take is to be added to the files subdir and the Portfile.

Last edited 5 years ago by philippetev (Philip Petev) (previous) (diff)

comment:3 in reply to:  2 Changed 5 years ago by mf2k (Frank Schima)

Replying to philippetev:

If failed build is not High priority, then what it is?

We have thousands of open tickets, many of which are build failures. Why is this build failure higher priority than any of those? The Macports team will decide what is High priority. Usually it is based on the number of users and ports affected.

comment:4 Changed 5 years ago by raimue (Rainer Müller)

Can you please attach the patch to this ticket? External hosters are known not to keep files reliable for long time archiving and are not accessible for everyone (think of corporate firewalls).

Changed 5 years ago by philippetev (Philip Petev)

Attachment: patch_ncurses6x.diff added

Patch for ncurses 6.x+

comment:5 Changed 5 years ago by philippetev (Philip Petev)

Done!

comment:6 Changed 5 years ago by ryandesign (Ryan Schmidt)

Keywords: haspatch added
Owner: set to mkae
Status: newassigned
Summary: Midnight Commander (ncurses) can't be builtmc @4.8.19 +ncurses: build fails with ncurses 6

comment:8 Changed 5 years ago by philippetev (Philip Petev)

That's right.

comment:9 Changed 5 years ago by mf2k (Frank Schima)

Owner: mkae deleted

comment:10 Changed 5 years ago by lyskov (Sergey Lyskov)

Upstream ticket now marked as fixed, could port be update to include the fix? Thanks,

comment:11 Changed 4 years ago by kurthindenburg (Kurt Hindenburg)

Owner: set to kurthindenburg
Resolution: fixed
Status: assignedclosed

In a98ae3b2b6ad380a4dd1a1f49bb1020f650b9cf2/macports-ports (master):

mc: update to 4.8.22

closes #53272
closes #54662

Note: See TracTickets for help on using tickets.