Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#54720 closed update (fixed)

bvi @1.3.2_1: update to 1.4.0

Reported by: l2dy (Zero King) Owned by: mtn88 (Max)
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc:
Port: bvi

Description


Attachments (4)

Portfile​ (898 bytes) - added by mtn88 (Max) 7 years ago.
patch-comm.c.diff​ (308 bytes) - added by mtn88 (Max) 7 years ago.
patch-re.c.diff​ (365 bytes) - added by mtn88 (Max) 7 years ago.
Portfile-bvi.diff​ (1.8 KB) - added by mtn88 (Max) 7 years ago.

Download all attachments as: .zip

Change History (16)

Changed 7 years ago by mtn88 (Max)

Attachment: Portfile​ added

Changed 7 years ago by mtn88 (Max)

Attachment: patch-comm.c.diff​ added

Changed 7 years ago by mtn88 (Max)

Attachment: patch-re.c.diff​ added

comment:1 Changed 7 years ago by l2dy (Zero King)

Where are the patches from?

Changed 7 years ago by mtn88 (Max)

Attachment: Portfile-bvi.diff​ added

comment:2 Changed 7 years ago by mtn88 (Max)

Port is updated to latest version. Please change ticket status to "submission" and commit the changes to the source tree. Thanks! Max

comment:3 in reply to:  2 Changed 7 years ago by l2dy (Zero King)

Replying to mtn88:

Please change ticket status to "submission"

This is an "update" ticket for an existing port, "submission" is for new ports.

What are the patches for?

comment:4 Changed 7 years ago by mtn88 (Max)

True, meant to write "update". Patches are for:

  • Portfile-bvi.diff​: Is patching the existing bvi Portfile to the latest version
  • patch-re.c.diff​ and patch-comm.c.diff​ are files required for the port itself

comment:5 in reply to:  1 Changed 7 years ago by mtn88 (Max)

Replying to l2dy:

Where are the patches from?

I created them. Originally submitted the port in 2002 or 2003. So here's an update ;-)

comment:6 in reply to:  4 ; Changed 7 years ago by l2dy (Zero King)

Replying to mtn88:

  • patch-re.c.diff​ and patch-comm.c.diff​ are files required for the port itself

I can build the port without these two patches (comment out patchfiles), why are they required?

Last edited 7 years ago by l2dy (Zero King) (previous) (diff)

comment:7 in reply to:  6 Changed 7 years ago by mtn88 (Max)

Replying to l2dy:

Replying to mtn88:

  • patch-re.c.diff​ and patch-comm.c.diff​ are files required for the port itself

I can build the port without these two patches (comment out patchfiles), why are they required?

Fixes some compiler warnings, but port compiles without. Your call.

comment:8 Changed 7 years ago by kencu (Ken)

this patch patch-re.c.diff would seem to change the way the port logic works, and might be important to look at carefully.

comment:9 in reply to:  8 Changed 7 years ago by l2dy (Zero King)

Replying to kencu:

this patch patch-re.c.diff would seem to change the way the port logic works, and might be important to look at carefully.

Exactly what I was about to say. Value of *s_end would change with the patch.

Edit: ++ take precedence over *, so s_end is effectively not used later within the if statement, but could be used elsewhere.

Last edited 7 years ago by l2dy (Zero King) (previous) (diff)

comment:10 Changed 7 years ago by l2dy (Zero King)

Resolution: → fixed
Status: new → closed

In 4c1fc8eeb13222776ed9d71e2859c0e47000da02/macports-ports:

bvi: update to 1.4.0

Fixes: #54720

comment:11 Changed 7 years ago by l2dy (Zero King)

Committed without the patches.

comment:12 Changed 7 years ago by mtn88 (Max)

Agree with removing the patches. Thanks @l2dy and @kencu for reviewing and committing!

Note: See TracTickets for help on using tickets.