Opened 7 years ago

Closed 7 years ago

#54754 closed defect (fixed)

qt5-qtbase @5.8.0_0 fails to build on MacOS 10.13

Reported by: rex4539 (Dimitris Apostolou) Owned by: MarcusCalhoun-Lopez (Marcus Calhoun-Lopez)
Priority: Normal Milestone:
Component: ports Version: 2.4.99
Keywords: highsierra haspatch Cc: mndavidoff (Monte Davidoff), libsystem-ethan, MaddTheSane (C.W. Betts), maehne (Torsten Maehne), bertrandrustle (Bertrand Rustle), fracai, gallafent
Port: qt5-qtbase

Description 

:info:build painting/qcoregraphics.mm:74:39: error: use of undeclared identifier 'InvalidContext'
:info:build     require_action(inContext != NULL, InvalidContext, err = paramErr);
:info:build                                       ^
:info:build painting/qcoregraphics.mm:75:38: error: use of undeclared identifier 'InvalidBounds'
:info:build     require_action(inBounds != NULL, InvalidBounds, err = paramErr);
:info:build                                      ^
:info:build painting/qcoregraphics.mm:76:37: error: use of undeclared identifier 'InvalidImage'
:info:build     require_action(inImage != NULL, InvalidImage, err = paramErr);
:info:build                                     ^
:info:build painting/qcoregraphics.mm:185:60: warning: 'NSCompositeSourceOver' is deprecated: first deprecated in macOS 10.12 [-Wdeprecated-declarations]
:info:build     [image drawInRect:iconRect fromRect:iconRect operation:NSCompositeSourceOver fraction:1.0 respectFlipped:YES hints:nil];
:info:build                                                            ^~~~~~~~~~~~~~~~~~~~~
:info:build                                                            NSCompositingOperationSourceOver
:info:build /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSGraphics.h:59:37: note: 'NSCompositeSourceOver' has been explicitly marked deprecated here
:info:build static const NSCompositingOperation NSCompositeSourceOver NS_DEPRECATED_WITH_REPLACEMENT_MAC("NSCompositingOperationSourceOver", 10.0, 10.12) = NSCompositingOperationSourceOver;

Attachments (2)

main.log​ (1.8 MB) - added by rex4539 (Dimitris Apostolou) 7 years ago.
macports_qt5-qtbase_fix-bug-54754.diff​ (2.9 KB) - added by bertrandrustle (Bertrand Rustle) 7 years ago.
Portfile patch incorporating the patch from upstream. Applying this in a local repo copy of the port directory fixes the build.

Download all attachments as: .zip

Change History (15)

Changed 7 years ago by rex4539 (Dimitris Apostolou)

Attachment: main.log​ added

comment:1 Changed 7 years ago by mf2k (Frank Schima)

Cc: MarcusCalhoun-Lopez removed
Owner: set to MarcusCalhoun-Lopez
Status: new → assigned

comment:2 Changed 7 years ago by mndavidoff (Monte Davidoff)

The same build failure occurs on macOS 10.12.6 with Xcode 9.0.

comment:3 Changed 7 years ago by mndavidoff (Monte Davidoff)

Cc: mndavidoff added

comment:4 Changed 7 years ago by MaddTheSane (C.W. Betts)

A quick-and-dirty hack seems to be to add -D__ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORES=1 to the compiler flags.

comment:5 Changed 7 years ago by libsystem-ethan

Cc: libsystem-ethan added

comment:6 Changed 7 years ago by MaddTheSane (C.W. Betts)

Cc: MaddTheSane added

comment:7 Changed 7 years ago by bertrandrustle (Bertrand Rustle)

Here's the upstream patch that fixes the issue:

​https://codereview.qt-project.org/#/c/201546/

comment:8 Changed 7 years ago by maehne (Torsten Maehne)

Cc: maehne added

Changed 7 years ago by bertrandrustle (Bertrand Rustle)

Attachment: macports_qt5-qtbase_fix-bug-54754.diff​ added

Portfile patch incorporating the patch from upstream. Applying this in a local repo copy of the port directory fixes the build.

comment:9 Changed 7 years ago by bertrandrustle (Bertrand Rustle)

Cc: bertrandrustle added

comment:10 Changed 7 years ago by fracai

Cc: fracai added

comment:11 Changed 7 years ago by gallafent

Cc: gallafent added

comment:12 Changed 7 years ago by MarcusCalhoun-Lopez (Marcus Calhoun-Lopez)

Keywords: haspatch added
Status: assigned → accepted

comment:13 Changed 7 years ago by Marcus Calhoun-Lopez <marcuscalhounlopez@…>

Resolution: → fixed
Status: accepted → closed

In 1dc99ed5f06da346688436f8e22f1106952b4098/macports-ports:

qt5*: fix build error with macOS 10.13 SDK

See ​https://bugreports.qt.io/browse/QTBUG-62266
See ​https://bugreports.qt.io/browse/QTBUG-62658

Fixes #54754
Fixes #54452

No revbump for qtconnectivity because port either builds correctly
or not at all.

Note: See TracTickets for help on using tickets.