Opened 7 years ago

Last modified 19 months ago

#54839 closed defect

Checksum mismatches for generated tarballs from GitHub — at Version 28

Reported by: raimue (Rainer Müller) Owned by:
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc: aggraef@…, aronnax@…, ben@…, cjones051073 (Chris Jones), ctreleaven@…, dbevans (David B. Evans), devans@…, eborisch@…, fanfarillo.gcc@…, g5pw@…, galexv@…, gclawes, gjasny@…, glenn@…, graemelawes@…, howarth.at.macports@…, jheiss@…, jonesc@…, juanrgar@…, l2dy (Zero King), leonardo@…, lists@…, lpsinger (Leo Singer), me@…, milmazz (Milton Mazzarri), mk@…, mojca@…, neumann@…, pebrc (Peter Brachwitz), ryandesign (Ryan Carsten Schmidt), ryandesign@…, sean@…, sean@…, stromnov@…, takeshi@…, thibaut@…, vince@…, drkp (Dan Ports), SickTeddyBear, hansgans
Port: HermesApp LucenePlusPlus MongoHub apbs cusp lua-xavante mosesdecoder scm_breeze subsurface zorba

Description (last modified by cjones051073 (Chris Jones))

Apparently, GitHub upgraded their software and changed the way git tarballs are generated due to a bugfix in upstream git. The produced tarballs will differ from those that have been generated before.

The checksums of the following ports have changed due to this (ran against [ffdb5922289aca17f166d14e3e91ecbe52278c10/macports-ports]):

Port Maintainer
ALPSCore galexv@…
apbs howarth.at.macports@…,openmaintainer
box2d stromnov@…,openmaintainer
certbot mps@… Schamschula,openmaintainer
cgminer
chapel takeshi@…,openmaintainer
cjdns l2dy@… l2dy,openmaintainer
coffee-script ryandesign@…,openmaintainer
cot glenn@…
csvToLedger ben@…
cusp sean@…,openmaintainer
DepreciateForLedger ben@…
docker
docker-machine
elixir me@… milmazz
expense.txt ben@…
faust-devel ryandesign@…,aggraef@…
faust2-devel ryandesign@…,aggraef@…
fbthrift sean@…,openmaintainer
fbthrift sean@…,openmaintainer
git-lfs raimue@… raimue,openmaintainer
gst-plugins-cairovis aronnax@… lpsinger
GTDtoCSV ben@…
Gyoto thibaut@…,openmaintainer
HermesApp ryandesign@… ryandesign,openmaintainer
htcondor aronnax@… lpsinger
hub lists@…
ifeffit joe.fowler@…,openmaintainer
Io
iTerm2 emer@…
jake ryandesign@…,openmaintainer
just casey@…
keybase sean@…,openmaintainer
keybinder ryandesign@…,openmaintainer
keybinder-3.0 ryandesign@…,openmaintainer
kops pebrc,openmaintainer
LedgerScheduler ben@…
libcdata
libcdatetime
libcerror
libcfile
libclocale
libcnotify
libcsplit
libcthreads
libewf
libgit2 juanrgar@…,devans@… dbevans
libiodbc snc@…,openmaintainer
libphonenumber-cpp devans@… dbevans,openmaintainer
litecoin mk@…,openmaintainer
lua-cgilua
lua-rings
lua-wsapi
lua-xavante
LucenePlusPlus
mame
meson
mogenerator
mongo-cxx-driver ryandesign@…,openmaintainer
mongo-tools ryandesign@… ryandesign,openmaintainer
MongoHub ryandesign@…,openmaintainer
mongrel2
mosesdecoder
myrepos gjasny@…,openmaintainer
mythtv-core.25 ctreleaven@…,openmaintainer
mythtv-core.26 ctreleaven@…,openmaintainer
nu2
ocaml-async-core
OpenCoarrays fanfarillo.gcc@…
pear-TCPDF
pficommon
phoenix g5pw@…,openmaintainer
phpsh
povray
QGIS vince@…
QLStephen
qoauth
racer sean@…,openmaintainer
rclone eborisch@…,openmaintainer
rekall
root5 jonesc@… cjones051073
scm_breeze g5pw@…,openmaintainer
ShiftIt
subsurface
syncthing-0.14 leonardo@…,openmaintainer
synergy
tDOM neumann@…
teleport graemelawes@… gclawes,openmaintainer
texworks mojca@…,openmaintainer
tidyp
time.txt ben@…
todotxt snc@…,openmaintainer
tpkg jheiss@…,openmaintainer
uzbl ryandesign@… ryandesign,openmaintainer
webkit-sharp ryandesign@…,openmaintainer
xctool sean@…,openmaintainer
xmlroff
zorba

I do not know if GitHub actually invalidated the generated tarballs from their download caches, so the following might not be conclusive and checksums that are deemed correct might be subject to change in the future.

To track the progress, please do not edit above table as-is but remove fixed ports from the port field in this ticket.

See also this similar report for Homebrew: https://github.com/Homebrew/homebrew-core/issues/18044

For reference, above list was generated with these commands:

$ grep -l -R '^github\.setup' . | xargs -I{} sh -c 'basename $(dirname {})' | while read port; do sudo port clean --all \; fetch --no-mirrors \ checksum || echo $port > github-failed.txt; done
$ while read port; do port info --line --name --maintainer $port; done < <(sort -f github-failed.txt) | awk -F$'\t' '{printf "|| %-40s || %s ||\n", $2, $1}'

Change History (28)

comment:1 Changed 7 years ago by raimue (Rainer Müller)

In order to fix these ports, please apply the recipe from wiki:PortfileRecipes#stealth-updates by adding a dist_subdir.

comment:2 Changed 7 years ago by raimue (Rainer Müller)

In 73194e3f3ba6e6435f28a4de68060cb7c98827d5/macports-ports:

git-lfs: Fix checksums for stealth distfile update

See: #54839

comment:3 Changed 7 years ago by raimue (Rainer Müller)

Cc: raimue raimue@… removed
Port: git-lfs removed

comment:4 Changed 7 years ago by nerdling (Jeremy Lavergne)

Cc: snc@… removed
Port: libiodbc todotxt removed

I did get a changed distfile for todotxt (07842f8/macports-ports), but libiodbc seems to still be correct.

Last edited 7 years ago by nerdling (Jeremy Lavergne) (previous) (diff)

comment:5 in reply to:  4 Changed 7 years ago by raimue (Rainer Müller)

Replying to nerdling:

but libiodbc seems to still be correct.

You are right, I only checked if the command was successful and the problem with libiodbc was unrelated and temporary (502 Bad Gateway). I noticed now that the list also contains some other errors such as 404 Not Found for some ports. However, they need to be looked into anyway, so I am not re-running the whole thing.

comment:6 Changed 7 years ago by Schamschula (Marius Schamschula)

In 8de513662f8647017c9f850c0146606ed9121154/macports-ports:

certbot: revision bump got stealth update 2 GitHub

See: #54839

comment:7 Changed 7 years ago by Schamschula (Marius Schamschula)

Cc: Schamschula mps@… removed

comment:8 Changed 7 years ago by lbschenkel (Leonardo Brondani Schenkel)

There's a new syncthing release scheduled to happen in 3 days; since installing the pre-built binaries still works and this port has no variants that would force building from source, I think that the number of impacted users is on the low side and we can afford to wait so I can kill two birds with one stone. Sounds reasonable?

Last edited 7 years ago by lbschenkel (Leonardo Brondani Schenkel) (previous) (diff)

comment:9 Changed 7 years ago by raimue (Rainer Müller)

Users of a non-default prefix will not receive binary archives, although I agree there are probably not many. Fixing the checksums will not affect existing installations in any way. We can assume the content of the distfiles has not changed as they are still based on the same git commit. There is no need to increase the revision when fixing the checksums and it will not cause any rebuilds.

comment:10 Changed 7 years ago by mojca (Mojca Miklavec)

I planned to seize the opportunity to update texworks to 0.6.2 to avoid doing workarounds, but I cannot make it compile. I'll see if I can fix the problems quickly. If not, I'll do a workaround.

comment:11 Changed 7 years ago by l2dy (Zero King)

In d7d06e889adaad74b8bd92d356d0bcd7f9aea989/macports-ports:

cjdns: Fix checksums for stealth distfile update

See: #54839

comment:12 Changed 7 years ago by l2dy (Zero King)

Cc: l2dy@… removed
Port: cjdns removed

comment:13 Changed 7 years ago by Schamschula (Marius Schamschula)

In 14721aee908d3a7a98becf1e6119d7c7893aebce/macports-ports:

iTerm2: update to version 3.0.15 (maintainer timeout)

Closes: #54806
also fixes GitHub stealth update:
See: #54839

comment:14 Changed 7 years ago by raimue (Rainer Müller)

Cc: emer@… removed
Port: iTerm2 removed

comment:15 Changed 7 years ago by Schamschula (Marius Schamschula)

Port: certbot removed

comment:16 Changed 7 years ago by casey (Casey Rodarmor)

Cc: casey removed

comment:17 Changed 7 years ago by casey (Casey Rodarmor)

Cc: casey added

comment:18 Changed 7 years ago by casey (Casey Rodarmor)

Cc: casey removed

comment:19 Changed 7 years ago by lbschenkel (Leonardo Brondani Schenkel)

syncthing-0.14 has now been upgraded to a new upstream version, that also addresses the checksum problem

comment:20 Changed 7 years ago by l2dy (Zero King)

Port: syncthing-0.14 removed

comment:21 Changed 7 years ago by joefowler (Joe Fowler)

See #54890: I tried to follow the instructions and update port ifeffit. But as @ryandesign has politely pointed out, I did not actually have to change the checksums.

So can you check again that ifeffit belongs on this list? If it does, then I guess I am totally confused about what to do.

comment:22 Changed 7 years ago by l2dy (Zero King)

Port: ifeffit removed

comment:23 Changed 7 years ago by drkp (Dan Ports)

Cc: drkp added

comment:24 Changed 7 years ago by raimue (Rainer Müller)

Cc: joefowler removed

I can confirm ifeffit was a false positive, follow-up in #54890.

comment:25 Changed 7 years ago by Dan R. K. Ports <drkp@…>

In 7c281354f28c9ddbcdb19dddec135e7df2f030ff/macports-ports:

osxfuse: set dist_subdir to prevent github-caused checksum mismatch

See #54839
Closes: #54892
Closes: #54898

comment:26 Changed 7 years ago by SickTeddyBear

Cc: SickTeddyBear added

comment:27 Changed 7 years ago by ryandesign (Ryan Carsten Schmidt)

Cc: hansgans added

Has duplicate #54910.

comment:28 Changed 7 years ago by cjones051073 (Chris Jones)

Description: modified (diff)

tbb fixed (also updated to 2017_U8).

Note: See TracTickets for help on using tickets.