inkscape @0.92.2: error: call to 'abs' is ambiguous

[tempesti0n1c]

Trying to install inkscape 0.92.2_0 and it wont complete. main.log attached.

[jmroot (Joshua Root)]

Looks like id.objID is not of any of the types for which abs() is defined. So genuinely invalid code according to strict C++ rules. Probably just needs a cast to an appropriate type.

[tempesti0n1c]

main.log of build failure on High Sierra attached, in case it's helpful

[michaellass (Michael Lass)]

Indeed, i->pathNext->id.objID is of type unsigned int, for which abs() does not make much sense. Replacing the line by the following should fix the issue and keep the code functional:

COLA_ASSERT(abs((int)i->pathNext->id.objID - (int)i->id.objID) != 2);

If nobody is quicker than me, I will report this upstream and add a corresponding patch to the Portfile.

[danchr (Dan Villiom Podlaski Christiansen)]

The port isn't openmaintainer, so I posted a PR: ​https://github.com/macports/macports-ports/pull/895

[raimue (Rainer Müller)]

I can reproduce the problem also on macOS 10.12 with Xcode 9. The patch needs to be applied unconditionally.

[abgandar (Alexander Wittig)]

Just for reference: the same problem also appears in the FreeBSD port for Inkscape (1). Their patch (2) is more or less the same as comment:12 and comment:13 propose.

(1) ​https://lists.freebsd.org/pipermail/freebsd-gnome/2016-June/034288.html
(2) ​https://svnweb.freebsd.org/ports/head/graphics/inkscape/files/patch-src_libavoid_connector.cpp?revision=416493&view=markup

[ryandesign (Ryan Carsten Schmidt)]

Has duplicate #55069.

[danchr (Dan Villiom Podlaski Christiansen)]

In 542661ba214f200c67ac40814b3ead3199c94f46/macports-ports:

inkscape: fix build in High Sierra (maintainer timeout)

The current version of Inkscape fails with a build error due to an
ambigious call to abs(). Indeed, i->pathNext->id.objID is of type
unsigned int, for which abs() does not make much sense. Adding a cast
to 'long' fixes it.

The root cause of the bug is likely that the code isn't strictly valid
C++, and so the version of Clang included with Xcode 9 rejects it,
where earlier versions of Clang accepted it. Since this is a build
fix, we don't bump the revision.

PR submitted two weeks ago, but the maintainer didn't respond.

(Based on suggestion by Michael Lass)

Fixes: #54886

[danchr (Dan Villiom Podlaski Christiansen)]

In 542661ba214f200c67ac40814b3ead3199c94f46/macports-ports:

inkscape: fix build in High Sierra (maintainer timeout)

The current version of Inkscape fails with a build error due to an
ambigious call to abs(). Indeed, i->pathNext->id.objID is of type
unsigned int, for which abs() does not make much sense. Adding a cast
to 'long' fixes it.

The root cause of the bug is likely that the code isn't strictly valid
C++, and so the version of Clang included with Xcode 9 rejects it,
where earlier versions of Clang accepted it. Since this is a build
fix, we don't bump the revision.

PR submitted two weeks ago, but the maintainer didn't respond.

(Based on suggestion by Michael Lass)

Fixes: #54886