qt5-qtbase @5.9.1_1+openssl: destroot warnings about reinplace

[dstrubbe (David Strubbe)]

I got a lot of warnings in destroot phase about reinplace, suggesting the reinplace commands may need to be updated, or should be removed. This is on OSX 10.12.6.

---> Staging qt5-qtbase into destroot

Warning: reinplace s|\${CMAKE_CURRENT_LIST_DIR}|/opt/local/libexec/qt5/lib/cmake/Qt5|g didn't change anything in /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_aqua_qt5/qt5-qtbase/work/destroot/opt/local/libexec/qt5/lib/cmake/Qt5/Qt5ConfigVersion.cmake
Warning: reinplace s|\${CMAKE_CURRENT_LIST_DIR}|/opt/local/libexec/qt5/lib/cmake/Qt5|g didn't change anything in /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_aqua_qt5/qt5-qtbase/work/destroot/opt/local/libexec/qt5/lib/cmake/Qt5/Qt5ModuleLocation.cmake
Warning: reinplace s|\${CMAKE_CURRENT_LIST_DIR}|/opt/local/libexec/qt5/lib/cmake/Qt5Concurrent|g didn't change anything in /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_aqua_qt5/qt5-qtbase/work/destroot/opt/local/libexec/qt5/lib/cmake/Qt5Concurrent/Qt5ConcurrentConfigVersion.cmake
Warning: reinplace s|\${CMAKE_CURRENT_LIST_DIR}|/opt/local/libexec/qt5/lib/cmake/Qt5Core|g didn't change anything in /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_aqua_qt5/qt5-qtbase/work/destroot/opt/local/libexec/qt5/lib/cmake/Qt5Core/Qt5CoreConfigExtrasMkspecDir.cmake
Warning: reinplace s|\${CMAKE_CURRENT_LIST_DIR}|/opt/local/libexec/qt5/lib/cmake/Qt5Core|g didn't change anything in /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_aqua_qt5/qt5-qtbase/work/destroot/opt/local/libexec/qt5/lib/cmake/Qt5Core/Qt5CoreConfigVersion.cmake
Warning: reinplace s|\${CMAKE_CURRENT_LIST_DIR}|/opt/local/libexec/qt5/lib/cmake/Qt5Core|g didn't change anything in /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_aqua_qt5/qt5-qtbase/work/destroot/opt/local/libexec/qt5/lib/cmake/Qt5Core/Qt5CTestMacros.cmake
Warning: reinplace s|\${CMAKE_CURRENT_LIST_DIR}|/opt/local/libexec/qt5/lib/cmake/Qt5DBus|g didn't change anything in /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_aqua_qt5/qt5-qtbase/work/destroot/opt/local/libexec/qt5/lib/cmake/Qt5DBus/Qt5DBusConfigExtras.cmake
Warning: reinplace s|\${CMAKE_CURRENT_LIST_DIR}|/opt/local/libexec/qt5/lib/cmake/Qt5DBus|g didn't change anything in /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_aqua_qt5/qt5-qtbase/work/destroot/opt/local/libexec/qt5/lib/cmake/Qt5DBus/Qt5DBusConfigVersion.cmake
Warning: reinplace s|\${CMAKE_CURRENT_LIST_DIR}|/opt/local/libexec/qt5/lib/cmake/Qt5DBus|g didn't change anything in /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_aqua_qt5/qt5-qtbase/work/destroot/opt/local/libexec/qt5/lib/cmake/Qt5DBus/Qt5DBusMacros.cmake
Warning: reinplace s|\${CMAKE_CURRENT_LIST_DIR}|/opt/local/libexec/qt5/lib/cmake/Qt5Gui|g didn't change anything in /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_aqua_qt5/qt5-qtbase/work/destroot/opt/local/libexec/qt5/lib/cmake/Qt5Gui/Qt5Gui_QCocoaIntegrationPlugin.cmake
Warning: reinplace s|\${CMAKE_CURRENT_LIST_DIR}|/opt/local/libexec/qt5/lib/cmake/Qt5Gui|g didn't change anything in /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_aqua_qt5/qt5-qtbase/work/destroot/opt/local/libexec/qt5/lib/cmake/Qt5Gui/Qt5Gui_QGifPlugin.cmake
Warning: reinplace s|\${CMAKE_CURRENT_LIST_DIR}|/opt/local/libexec/qt5/lib/cmake/Qt5Gui|g didn't change anything in /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_aqua_qt5/qt5-qtbase/work/destroot/opt/local/libexec/qt5/lib/cmake/Qt5Gui/Qt5Gui_QICOPlugin.cmake
Warning: reinplace s|\${CMAKE_CURRENT_LIST_DIR}|/opt/local/libexec/qt5/lib/cmake/Qt5Gui|g didn't change anything in /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_aqua_qt5/qt5-qtbase/work/destroot/opt/local/libexec/qt5/lib/cmake/Qt5Gui/Qt5Gui_QJpegPlugin.cmake
Warning: reinplace s|\${CMAKE_CURRENT_LIST_DIR}|/opt/local/libexec/qt5/lib/cmake/Qt5Gui|g didn't change anything in /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_aqua_qt5/qt5-qtbase/work/destroot/opt/local/libexec/qt5/lib/cmake/Qt5Gui/Qt5Gui_QMinimalIntegrationPlugin.cmake
Warning: reinplace s|\${CMAKE_CURRENT_LIST_DIR}|/opt/local/libexec/qt5/lib/cmake/Qt5Gui|g didn't change anything in /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_aqua_qt5/qt5-qtbase/work/destroot/opt/local/libexec/qt5/lib/cmake/Qt5Gui/Qt5Gui_QOffscreenIntegrationPlugin.cmake
Warning: reinplace s|\${CMAKE_CURRENT_LIST_DIR}|/opt/local/libexec/qt5/lib/cmake/Qt5Gui|g didn't change anything in /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_aqua_qt5/qt5-qtbase/work/destroot/opt/local/libexec/qt5/lib/cmake/Qt5Gui/Qt5Gui_QTuioTouchPlugin.cmake
Warning: reinplace s|\${CMAKE_CURRENT_LIST_DIR}|/opt/local/libexec/qt5/lib/cmake/Qt5Gui|g didn't change anything in /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_aqua_qt5/qt5-qtbase/work/destroot/opt/local/libexec/qt5/lib/cmake/Qt5Gui/Qt5GuiConfigExtras.cmake
Warning: reinplace s|\${CMAKE_CURRENT_LIST_DIR}|/opt/local/libexec/qt5/lib/cmake/Qt5Gui|g didn't change anything in /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_aqua_qt5/qt5-qtbase/work/destroot/opt/local/libexec/qt5/lib/cmake/Qt5Gui/Qt5GuiConfigVersion.cmake
Warning: reinplace s|\${CMAKE_CURRENT_LIST_DIR}|/opt/local/libexec/qt5/lib/cmake/Qt5Network|g didn't change anything in /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_aqua_qt5/qt5-qtbase/work/destroot/opt/local/libexec/qt5/lib/cmake/Qt5Network/Qt5Network_QCoreWlanEnginePlugin.cmake
Warning: reinplace s|\${CMAKE_CURRENT_LIST_DIR}|/opt/local/libexec/qt5/lib/cmake/Qt5Network|g didn't change anything in /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_aqua_qt5/qt5-qtbase/work/destroot/opt/local/libexec/qt5/lib/cmake/Qt5Network/Qt5Network_QGenericEnginePlugin.cmake
Warning: reinplace s|\${CMAKE_CURRENT_LIST_DIR}|/opt/local/libexec/qt5/lib/cmake/Qt5Network|g didn't change anything in /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_aqua_qt5/qt5-qtbase/work/destroot/opt/local/libexec/qt5/lib/cmake/Qt5Network/Qt5NetworkConfigVersion.cmake
Warning: reinplace s|\${CMAKE_CURRENT_LIST_DIR}|/opt/local/libexec/qt5/lib/cmake/Qt5OpenGL|g didn't change anything in /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_aqua_qt5/qt5-qtbase/work/destroot/opt/local/libexec/qt5/lib/cmake/Qt5OpenGL/Qt5OpenGLConfigVersion.cmake
Warning: reinplace s|\${CMAKE_CURRENT_LIST_DIR}|/opt/local/libexec/qt5/lib/cmake/Qt5OpenGLExtensions|g didn't change anything in /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_aqua_qt5/qt5-qtbase/work/destroot/opt/local/libexec/qt5/lib/cmake/Qt5OpenGLExtensions/Qt5OpenGLExtensionsConfigVersion.cmake
Warning: reinplace s|\${CMAKE_CURRENT_LIST_DIR}|/opt/local/libexec/qt5/lib/cmake/Qt5PrintSupport|g didn't change anything in /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_aqua_qt5/qt5-qtbase/work/destroot/opt/local/libexec/qt5/lib/cmake/Qt5PrintSupport/Qt5PrintSupport_QCocoaPrinterSupportPlugin.cmake
Warning: reinplace s|\${CMAKE_CURRENT_LIST_DIR}|/opt/local/libexec/qt5/lib/cmake/Qt5PrintSupport|g didn't change anything in /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_aqua_qt5/qt5-qtbase/work/destroot/opt/local/libexec/qt5/lib/cmake/Qt5PrintSupport/Qt5PrintSupportConfigVersion.cmake
Warning: reinplace s|\${CMAKE_CURRENT_LIST_DIR}|/opt/local/libexec/qt5/lib/cmake/Qt5Sql|g didn't change anything in /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_aqua_qt5/qt5-qtbase/work/destroot/opt/local/libexec/qt5/lib/cmake/Qt5Sql/Qt5SqlConfigVersion.cmake
Warning: reinplace s|\${CMAKE_CURRENT_LIST_DIR}|/opt/local/libexec/qt5/lib/cmake/Qt5Test|g didn't change anything in /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_aqua_qt5/qt5-qtbase/work/destroot/opt/local/libexec/qt5/lib/cmake/Qt5Test/Qt5TestConfigExtras.cmake
Warning: reinplace s|\${CMAKE_CURRENT_LIST_DIR}|/opt/local/libexec/qt5/lib/cmake/Qt5Test|g didn't change anything in /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_aqua_qt5/qt5-qtbase/work/destroot/opt/local/libexec/qt5/lib/cmake/Qt5Test/Qt5TestConfigVersion.cmake
Warning: reinplace s|\${CMAKE_CURRENT_LIST_DIR}|/opt/local/libexec/qt5/lib/cmake/Qt5Widgets|g didn't change anything in /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_aqua_qt5/qt5-qtbase/work/destroot/opt/local/libexec/qt5/lib/cmake/Qt5Widgets/Qt5WidgetsConfigVersion.cmake
Warning: reinplace s|\${CMAKE_CURRENT_LIST_DIR}|/opt/local/libexec/qt5/lib/cmake/Qt5Widgets|g didn't change anything in /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_aqua_qt5/qt5-qtbase/work/destroot/opt/local/libexec/qt5/lib/cmake/Qt5Widgets/Qt5WidgetsMacros.cmake
Warning: reinplace s|\${CMAKE_CURRENT_LIST_DIR}|/opt/local/libexec/qt5/lib/cmake/Qt5Xml|g didn't change anything in /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_aqua_qt5/qt5-qtbase/work/destroot/opt/local/libexec/qt5/lib/cmake/Qt5Xml/Qt5XmlConfigVersion.cmake

[MarcusCalhoun-Lopez (Marcus Calhoun-Lopez)]

The reason is that the same reinplace code run for all the cmake files of all the subports of qt5.
This seemed easier than trying to dig through several cmake files of several subports to see which ones actually neeed it.
I suppose I can write some code to try and determine if the reinplace is actually needed, but the current situation isn't doing any harm is it?

[dstrubbe (David Strubbe)]

I guess it isn't actually harming the build, but it looks alarming to see such a large number of warnings come up. If there is a reasonable way to only apply where needed, and suppress these warnings, I think that would be helpful.

[ryandesign (Ryan Carsten Schmidt)]

Use reinplace's -q flag to indicate that you are aware that it will not always replace something.

[MarcusCalhoun-Lopez (Marcus Calhoun-Lopez)]

In 5ad1525cabf3847d677e1ba8a4d4ef040d9edbfa/macports-ports:

qt5*: suppress reinplace warning

Fixes #54973