Opened 6 years ago

Closed 4 years ago

#55138 closed defect (fixed)

magicspp @2.29.4: error: ordered comparison between pointer and zero

Reported by: hbai24 Owned by: tenomoto (Takeshi Enomoto)
Priority: Normal Milestone:
Component: ports Version: 2.4.2
Keywords: Cc:
Port: magicspp

Description

Hello,

I tried to install CDO with MacPorts, but failed. The error seemed to be with magicspp. This was my first time to install with MacPorts, and I did't have a clue what's wrong. My macOS is 10.12.6, Xcode version is 9.0.1, and MacPorts version is 2.4.2. Following is the error massage:

sudo port install cdo +grib_api +magicspp +szip
--->  Computing dependencies for cdo
The following dependencies will be installed: 
 cunit
 magicspp
 udunits2
Continue? [Y/n]: Y
--->  Building magicspp
Error: Failed to build magicspp: command execution failed
Error: See /opt/local/var/macports/logs/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_science_magicspp/magicspp/main.log for details.
Error: Follow https://guide.macports.org/#project.tickets to report a bug.
Error: Processing of port cdo failed

I also attached my log file. If you need any additional information, please let me know. Any reply is appreciated!! Thanks!

Attachments (1)

main.log (2.1 MB) - added by hbai24 6 years ago.
log file

Change History (6)

Changed 6 years ago by hbai24

Attachment: main.log added

log file

comment:1 Changed 6 years ago by mf2k (Frank Schima)

Cc: hbai24 removed
Keywords: sierra removed
Owner: set to tenomoto
Port: magicspp added; CDO removed
Status: newassigned

In the future, please fill in the Port field with the port that fails to build and Cc the port maintainers (port info --maintainers magicspp).

As reporter, you are automatically Cc'ed.

comment:2 Changed 6 years ago by tenomoto (Takeshi Enomoto)

In 92b1bd3039c85f0df525339b0ce41c3ac603b541/macports-ports:

replace grib_api by eCcodes

ecCodes: add to MacPorts
gnudatalanguage: update to 0.9.7. use gsshg-bin-*.zip
py-pygrib: add support for python-3.6
cdo: make +eccodes default
libemos: update to 4.5.1. add patch to avoid conflict of bufr_filter with ecCodes
magicspp: update to 2.34.3. use perl 5.26. add patch to stop adding -Wl,-framework to CAIRO_LIBRARIES
metview: update to 4.9.1
Closes: #52233
See: #55138
See: #55208

comment:3 in reply to:  2 ; Changed 6 years ago by pgf

Replying to tenomoto:

In 92b1bd3039c85f0df525339b0ce41c3ac603b541/macports-ports:

replace grib_api by eCcodes

ecCodes: add to MacPorts
gnudatalanguage: update to 0.9.7. use gsshg-bin-*.zip
py-pygrib: add support for python-3.6
cdo: make +eccodes default
libemos: update to 4.5.1. add patch to avoid conflict of bufr_filter with ecCodes
magicspp: update to 2.34.3. use perl 5.26. add patch to stop adding -Wl,-framework to CAIRO_LIBRARIES
metview: update to 4.9.1
Closes: #52233
See: #55138
See: #55208


The inline comment (# exclude -Wl,-framework) in the magicspp Portfile cause the build to fail on my mac:

patchfiles          patch-CMakeLists.txt.diff \
                    patch-cmake-FindPangoCairo.cmake.diff # exclude -Wl,-framework

Removing it solved the issue.

comment:4 in reply to:  description Changed 4 years ago by ryandesign (Ryan Carsten Schmidt)

Replying to hbai24:

Error: See /opt/local/var/macports/logs/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_science_magicspp/magicspp/main.log for details.

The log says the problem was:

src/decoders/GribDecoder.cc:264:18: error: ordered comparison between pointer and zero ('grib_handle *' and 'int')
    if ( handle_ <=0 ) {
         ~~~~~~~ ^ ~

comment:5 in reply to:  3 Changed 4 years ago by ryandesign (Ryan Carsten Schmidt)

Resolution: fixed
Status: assignedclosed
Summary: Failed to build magicspp: command execution failedmagicspp @2.29.4: error: ordered comparison between pointer and zero

Replying to pgf:

The inline comment (# exclude -Wl,-framework) in the magicspp Portfile cause the build to fail on my mac:

patchfiles          patch-CMakeLists.txt.diff \
                    patch-cmake-FindPangoCairo.cmake.diff # exclude -Wl,-framework

Removing it solved the issue.

The misplaced comment was fixed in [a9e89f6e3ff706676fcffab721c605d902d2de9f/macports-ports].

This ticket is years old and the port has been updated several times since the ticket was filed, so I'll assume the original problem was fixed. If not, please file a new ticket with a new main.log from the latest version of the port.

Note: See TracTickets for help on using tickets.