apg: Not UsingTheRightCompiler

[Polyergic (Shad Sterling)]

Reinstalling all ports after upgrading to High Sierra, a few are failing to build, including apg:

:notice:build --->  Building apg
:debug:build Executing org.macports.build (apg)
:debug:build Environment: 
:debug:build CC_PRINT_OPTIONS='YES'
:debug:build CC_PRINT_OPTIONS_FILE='/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_security_apg/apg/work/.CC_PRINT_OPTIONS'
:debug:build CPATH='/opt/local/include'
:debug:build LIBRARY_PATH='/opt/local/lib'
:debug:build MACOSX_DEPLOYMENT_TARGET='10.13'
:info:build Executing:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_security_apg/apg/work/apg-2.2.3" && /usr/bin/make -j4 -w all 
:debug:build system:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_security_apg/apg/work/apg-2.2.3" && /usr/bin/make -j4 -w all 
:info:build make: Entering directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_security_apg/apg/work/apg-2.2.3'
:info:build gcc -Wall -DCLISERV -DAPG_DONOTUSE_SHA -o apgd bloom.c ./sha/sha.c ./cast/cast.c rnd.c pronpass.c randpass.c restrict.c errors.c apg.c getopt.c convert.c  -lm
:info:build In file included from /usr/include/sys/cdefs.h:587:0,
:info:build                  from /usr/include/stdio.h:64,
:info:build                  from errors.c:30:
:info:build /usr/include/sys/syslog.h:227:124: error: expected ',' or ';' before '__asm'
:info:build  void syslog(int, const char *, ...) __printflike(2, 3) __not_tail_called __DARWIN_ALIAS_STARTING(__MAC_10_13, __IPHONE_NA, __DARWIN_EXTSN(syslog));
:info:build                                                                                                                             ^
:info:build In file included from /usr/include/sys/cdefs.h:587:0,
:info:build                  from /usr/include/stdio.h:64,
:info:build                  from apg.c:33:
:info:build /usr/include/sys/syslog.h:227:124: error: expected ',' or ';' before '__asm'
:info:build  void syslog(int, const char *, ...) __printflike(2, 3) __not_tail_called __DARWIN_ALIAS_STARTING(__MAC_10_13, __IPHONE_NA, __DARWIN_EXTSN(syslog));
:info:build                                                                                                                             ^
:info:build make: *** [apgd] Error 1

[raimue (Rainer Müller)]

The underlying issue has already been ​reported at GCC upstream.

However, this is a case for UsingTheRightCompiler. This port is not supposed to use plain gcc, but needs to use ${configure.cc}.

[kencu (Ken)]

There seem to be a few examples in the 10.13 headers where __attribute__ comes before __asm and gcc doesn't like that combination. Apparently clang can deal with it, so I suppose that's why it slipped through.

[ryandesign (Ryan Carsten Schmidt)]

In dfc59c3d40ae025be34be4907298a580709ad089/macports-ports:

apg: Use the right compiler and -arch flags

Closes: #55159

Also add universal variant.