Opened 6 years ago

Closed 6 years ago

#55221 closed enhancement (fixed)

wxWidgets-3.0-libcxx: remove the port

Reported by: mojca (Mojca Miklavec) Owned by: mojca (Mojca Miklavec)
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc: MarcusCalhoun-Lopez (Marcus Calhoun-Lopez), yan12125 (Chih-Hsuan Yen)
Port: FileZilla, wxWidgets-3.0-libcxx

Description

I would like to suggest getting rid of wxWidgets-libcxx (now that we have wxWidgets-cxx11 anyway).

It seems that only FileZilla is trying to use it (it was me who added that weird code long time ago), but I'm pretty sure that FileZilla in its current form is not supported on < 10.9. I don't know whether using cxx11 1.1 would help in any way.

Attachments (1)

FileZilla.Portfile.diff (3.4 KB) - added by mojca (Mojca Miklavec) 6 years ago.
Replace wxWidgets in FileZilla

Download all attachments as: .zip

Change History (8)

comment:1 Changed 6 years ago by mojca (Mojca Miklavec)

Port: wxWidgets-3.0-libcxx added; wxWidgets-libcxx removed
Summary: wxWidgets-libcxx: remove the portwxWidgets-3.0-libcxx: remove the port

comment:2 Changed 6 years ago by mojca (Mojca Miklavec)

Random note. The libfilezilla library can still be compiled on 10.7. On 10.6 it fails to build with the same error as reported here:

file.cpp:142:14: error: use of undeclared identifier 'O_CLOEXEC'
        int flags = O_CLOEXEC;
                    ^
1 error generated.

Just as a reference point when thinking about how far back we might want to go with testing.

Changed 6 years ago by mojca (Mojca Miklavec)

Attachment: FileZilla.Portfile.diff added

Replace wxWidgets in FileZilla

comment:3 Changed 6 years ago by mojca (Mojca Miklavec)

Yen: I atteched my proposed changes for FileZilla. Can you please have a look. It would probably be most interesting to test this on 10.7 or 10.8. If this works fine, my next step would be to get rid of wxWidgets-3.0-libcxx as there's really no need for it.

Last edited 6 years ago by mojca (Mojca Miklavec) (previous) (diff)

comment:4 in reply to:  2 Changed 6 years ago by kencu (Ken)

Replying to mojca:

file.cpp:142:14: error: use of undeclared identifier 'O_CLOEXEC'

int flags = O_CLOEXEC;

1 error generated. }}}

This error is noted now and then on 10.6.8. Sometimes I have seen it fixed properly, by manually closing the file after using it. Most often, with many examples on MacPorts, it is just defined to 0 like this:

configure.cppflags-append -DO_CLOEXEC=0
Last edited 6 years ago by kencu (Ken) (previous) (diff)

comment:5 Changed 6 years ago by kencu (Ken)

fixing O_CLOEXEC gets further on 10.6, but there is at least one further missing function not yet replaced by snowleopard_fixes. Will have to work on this more later, but for now it is still broken on 10.6.

comment:6 Changed 6 years ago by mojca (Mojca Miklavec)

In 96692d1a2b246a29cd2c19e31ddca7fc6680514f/macports-ports:

FileZilla: clean up wxWidgets dependencies

See: #55221

comment:7 Changed 6 years ago by mojca (Mojca Miklavec)

Owner: set to mojca
Resolution: fixed
Status: newclosed

In f3ed70a1c867bf748d57cec9bcc44bd417c3fc7f/macports-ports:

wxWidgets-3.0-libcxx: delete port

Closes: #55221

Note: See TracTickets for help on using tickets.