Opened 6 years ago

Closed 6 years ago

#55268 closed defect (fixed)

syntax highlighting broken while composing email with vim in neomutt

Reported by: mimaoffice (Michele Marcionelli) Owned by: lbschenkel (Leonardo Brondani Schenkel)
Priority: Normal Milestone:
Component: ports Version: 2.4.2
Keywords: Cc: l2dy (Zero King)
Port: neomutt

Description

Since the new version of neomutt (@20171027_1) the syntax highlighting in vim is broken while composing emails. The problem is caused by the fact, that the temporary filename for the email begins now with neomutt-... and no more with mutt-... (see attachment).

One could solve the problem by modifying the vim config file /usr/share/vim/vimNN/filetype.vim, but this is not the best solution...

What do you suggest?

Bests, Michele

PS: hopefully the last ticket for neomutt for a while ;-)

Attachments (1)

Screen Shot 2017-11-07 at 14.30.36.png (147.0 KB) - added by mimaoffice (Michele Marcionelli) 6 years ago.

Download all attachments as: .zip

Change History (12)

Changed 6 years ago by mimaoffice (Michele Marcionelli)

comment:1 Changed 6 years ago by lbschenkel (Leonardo Brondani Schenkel)

This kind of issue you should report directly to upstream, because that's not really a bug in the MacPorts package. NeoMutt went through a lot of changes lately, including a name change, so you should let them know that some of these changes broke existing workflows.

Please submit it here: https://github.com/neomutt/neomutt/issues

Last edited 6 years ago by lbschenkel (Leonardo Brondani Schenkel) (previous) (diff)

comment:2 Changed 6 years ago by mimaoffice (Michele Marcionelli)

comment:3 Changed 6 years ago by lbschenkel (Leonardo Brondani Schenkel)

I'm going to leave this open in order to track the resolution. If all else fails, we can solve this in "MacPorts land" by adding a patch to vim or neomutt (because I agree that it is an important feature that should keep working) but hopefully this should be fixed upstream. There's also NeoVim to consider (the one I personally use).

comment:4 Changed 6 years ago by mf2k (Frank Schima)

Cc: l2dy added; lbschenkel removed
Owner: set to lbschenkel
Status: newassigned

comment:5 Changed 6 years ago by lbschenkel (Leonardo Brondani Schenkel)

@Michele: Vim should "recognize" NeoMutt once https://github.com/macports/macports-ports/pull/1009 is merged.

For NeoVim, which should incorporate the equivalent changes soon, I'm thinking about submitting one of the following to the maintainer:

  • a patch to the runtime files with the NeoMutt changes backported
  • introducing a neovim-devel subport so it's possible to use/test recent upstream changes before waiting for next official release (more likely)

comment:6 Changed 6 years ago by raimue (Rainer Müller)

In 4c167971f7193d587eee1be35a487051cb12f4fd/macports-ports:

vim: Update to version 8.0.1272

See: #55268

comment:7 Changed 6 years ago by raimue (Rainer Müller)

For NeoVim, we could add this as a local patch if needed. I did not add any neovim-devel port, as I do not follow the upstream development too closely, so I would not know when it is worth to update such a port.

However, in general the quickest workaround would be to just add the corresponding autocmd to your (Neo)Vim configuration files in ~/.vim/filetype.vim:

au BufNewFile,BufRead neomutt-*-\w\+,neomutt[[:alnum:]_-]\\\{6\} setf mail

comment:8 Changed 6 years ago by lbschenkel (Leonardo Brondani Schenkel)

@raimue: I have updated NeoVim earlier today to 2.1, which was just released less than 24h ago, and contains the necessary upstream changes.

I do keep track of upstream development, so in case something interesting comes up next time I may submit a neovim-devel port. I will volunteer to be the maintainer for it.

comment:9 Changed 6 years ago by lbschenkel (Leonardo Brondani Schenkel)

@Michele: I can see that the new version of Vim is available in the ports tree. Please confirm that the syntax highlighting now works for you so I can close this ticket.

comment:10 Changed 6 years ago by mimaoffice (Michele Marcionelli)

@Leonardo: Now everything works find. Thx!!

comment:11 Changed 6 years ago by lbschenkel (Leonardo Brondani Schenkel)

Resolution: fixed
Status: assignedclosed
Note: See TracTickets for help on using tickets.