libpsl: download data files in fetch phase, not in post-extract

[Schamschula (Marius Schamschula)]

Snow Leopard and Leopard often fail to download files from https servers. In this case we are attempting to download a file in the post-extract phase. There is no easy way to avoid the certificate error, give then curl fetch command. If this file was downloaded in the fetch phase, it would be relatively easy to manually download using curl -k or wget.

--->  Extracting libpsl
Error: Failed to extract libpsl: SSL certificate problem, verify that the CA cert is OK. Details:
error:14090086:SSL routines:SSL3_GET_SERVER_CERTIFICATE:certificate verify failed
Error: See /opt/local/var/macports/logs/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_net_libpsl/libpsl/main.log for details.
Error: Problem while installing libpsl
Error: Follow https://guide.macports.org/#project.tickets to report a bug.

[Schamschula (Marius Schamschula)]

libpsl is now a default dependency for both curl and wget.

See

[9fbfc98ccf4c559caf29570d4873d05e10de7a76/macports-ports]

and

[8b1bbc9f8412c8fd1d71db2096113cca4a4e42bc/macports-ports]

[ryandesign (Ryan Carsten Schmidt)]

Yup. See ​https://lists.macports.org/pipermail/macports-dev/2017-November/036877.html

[ryandesign (Ryan Carsten Schmidt)]

Also, I encourage you to use a tarball-style URL for the psldata file, to match the port's main distfile. If you really want to use an archive-style URL, then at least add a dummy parameter to the master_sites so that you can adjust the psldata filename to include a string like "psldata", to avoid confusion with the libpsl distfiles.

[ryandesign (Ryan Carsten Schmidt)]

This is a situation where it would be great if #55455 were implemented.

[rmottola (Riccardo)]

I have exactly this issue on Leopard. Is there a known workaround? a fix?

I tried issuing the command several times and no change.

[svensen]

I did some modifications to the Portfile:

# set psl_data_url        https://github.com/publicsuffix/list/archive
set psl_data_url        https://codeload.github.com/publicsuffix/list/zip

post-extract {
    system "/usr/bin/curl -s -k -o \"${psl_data_dir}/${psl_data_archive}\" \"${psl_data_url}/${psl_data_commit}\""
#    curl fetch ${psl_data_url}/${psl_data_archive} ${psl_data_dir}/${psl_data_archive}

There might be a more appropriate fix. However, this works for me.

[Schamschula (Marius Schamschula)]

Replying to svensen:

I did some modifications to the Portfile:

# set psl_data_url        https://github.com/publicsuffix/list/archive
set psl_data_url        https://codeload.github.com/publicsuffix/list/zip

post-extract {
    system "/usr/bin/curl -s -k -o \"${psl_data_dir}/${psl_data_archive}\" \"${psl_data_url}/${psl_data_commit}\""
#    curl fetch ${psl_data_url}/${psl_data_archive} ${psl_data_dir}/${psl_data_archive}

There might be a more appropriate fix. However, this works for me.

This also worked for me. I must have missed a step when I manually downloaded the list data archive.

[rmottola (Riccardo)]

I suppose I had to modify the Portfile manually to test this patch? I did and it installed correctly, so the hack did it for me!

[ballapete (Peter "Pete" Dyballa)]

Builds with these two changes also on PPC Tiger.

[udbraumann]

Interestingly, on my 10.5.8 PPC I receive a similar, but not the same error:

--->  Extracting libpsl
Error: Failed to extract libpsl: error:0D0890A1:asn1 encoding routines:ASN1_verify:unknown message digest algorithm

[khepler]

My Xserve G5 and Powerbook G4, both running 10.5.8, emit the error in the ticket description. That is:

Error: Failed to extract libpsl: SSL certificate problem, verify that the CA cert is OK. Details:
error:14090086:SSL routines:SSL3_GET_SERVER_CERTIFICATE:certificate verify failed

[ryandesign (Ryan Carsten Schmidt)]

The best solution is for the portfile to use the ​release download the project makes available.

[ryandesign (Ryan Carsten Schmidt)]

Granted, this uses a slightly older data file. The one in the release download is from 9/14/2017, while the one the port is currently downloading is from 10/28/2017. If it's desired to update to newer data files than what's in the release download, then I can provide an alternate patch.

[ryandesign (Ryan Carsten Schmidt)]

Has duplicate #55509.

[ryandesign (Ryan Carsten Schmidt)]

In bcd63d68138b957ea67d02e0eee939d89f5142ff/macports-ports:

libpsl: Download the second distfile in the fetch phase too

Closes: #55440