Opened 6 years ago

Closed 6 years ago

#55459 closed defect (fixed)

qgis3: Don't hardcode /Applications/MacPorts

Reported by: ryandesign (Ryan Carsten Schmidt) Owned by: Veence (Vincent)
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch Cc:
Port: qgis3

Description

The qgis3 portfile says: 

post-destroot {
    # qgis_bench app doesn’t link properly. Who uses this anyway????
    system -W ${destroot}/Applications/MacPorts/QGIS.app/Contents/MacOS/bin "rm -rf qgis_bench.app"
}

You shouldn't call out to system for functionality already available in MacPorts (MacPorts has the functionality to delete files); and you shouldn't assume the applications are in /Applications/MacPorts (the user can configure MacPorts to put them somewhere else).

To fix both issues, please change that system command to: 

    delete ${destroot}${applications_dir}/QGIS.app/Contents/MacOS/bin/qgis_bench.app

Change History (1)

comment:1 Changed 6 years ago by Veence (Vincent)

Resolution: → fixed
Status: new → closed

Done! Thanks Ryan, as usual, for perusing and pointing out all my mistakes!

Note: See TracTickets for help on using tickets.