Opened 8 months ago

Closed 7 months ago

Last modified 7 months ago

#55466 closed defect (fixed)

tao @ 6.4.5 (2.4.5) Support Sierra and daemondo

Reported by: lockhart (Thomas Lockhart) Owned by: mf2k (Frank Schima)
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch maintainer Cc: ryandesign (Ryan Schmidt)
Port: tao

Description

Sierra offers support for clockid_t, CLOCK_REALTIME, and CLOCK_MONOTONIC. This patch set modifies a header file to use these features on Sierra. WIthout this patch the C++ compiler throws warnings about multiply-defined symbols. It seems that the original daemon startup using a .plist file is broken and probably has been for some time. This patch set removes the .plist file included in the port in favor of defining startupitem.executable in the Portfile. Please remove files/org.macports.tao_cosnaming.plist from the port.

Attachments (2)

Portfile.diff (2.6 KB) - added by lockhart (Thomas Lockhart) 8 months ago.
Remove explicit .plist and add a patch for the TAO Sierra configuration file.
patch-ace-config-macosx-sierra.h.diff (362 bytes) - added by lockhart (Thomas Lockhart) 8 months ago.
Adjust existing Sierra configuration header to compile cleanly. Will also push upstream to TAO developers.

Download all attachments as: .zip

Change History (10)

Changed 8 months ago by lockhart (Thomas Lockhart)

Attachment: Portfile.diff added

Remove explicit .plist and add a patch for the TAO Sierra configuration file.

Changed 8 months ago by lockhart (Thomas Lockhart)

Adjust existing Sierra configuration header to compile cleanly. Will also push upstream to TAO developers.

comment:1 Changed 8 months ago by lockhart (Thomas Lockhart)

Feedback on using startupitem.executable and why the original .plist file no longer works would be appreciated.

comment:2 Changed 7 months ago by lockhart (Thomas Lockhart)

A new version of TAO has been released which includes patches mentioned here. However the new version has a build issue (possibly due to a mispackaged tarball) so please proceed with this version for now. Thanks!

Last edited 7 months ago by lockhart (Thomas Lockhart) (previous) (diff)

comment:3 Changed 7 months ago by mf2k (Frank Schima)

Resolution: wontfix
Status: newclosed

OK. Please either re-open this ticket or just create a new one when ready.

comment:4 in reply to:  3 Changed 7 months ago by lockhart (Thomas Lockhart)

Resolution: wontfix
Status: closedreopened

Replying to mf2k:

OK. Please either re-open this ticket or just create a new one when ready.

Thanks Frank. I just updated my comment after running into build issues with the new version. Can we please go ahead and update the port with this version and with this (new) patch file? Thanks!

comment:5 Changed 7 months ago by mf2k (Frank Schima)

To be clear, are the following files in the files directory no longer needed?

  • org.macports.tao_cosnaming.plist
  • patch-ace-config-macosx-mountainlion.h.diff
  • patch-include-makeinclude-platform_macosx_mountainlion.GNU.diff

comment:6 in reply to:  5 Changed 7 months ago by lockhart (Thomas Lockhart)

Replying to mf2k:

To be clear, are the following files in the files directory no longer needed?

  • org.macports.tao_cosnaming.plist
  • patch-ace-config-macosx-mountainlion.h.diff
  • patch-include-makeinclude-platform_macosx_mountainlion.GNU.diff

Yes. Thanks for asking!

comment:7 Changed 7 months ago by mf2k (Frank Schima)

Owner: set to mf2k
Resolution: fixed
Status: reopenedclosed

In 3014d6ecb631f751d94066d5a6e34d2cb9e282d7/macports-ports:

tao: Support Sierra and daemondo

  • Remove unused patchfiles

Fixes: #55466

comment:8 Changed 7 months ago by lockhart (Thomas Lockhart)

Thanks!

Note: See TracTickets for help on using tickets.