Opened 6 years ago

Closed 6 years ago

Last modified 2 years ago

#55467 closed enhancement (fixed)

Portgroup bitbucket-1.0.tcl shouldn't set name in subport

Reported by: nortcele Owned by: neverpanic (Clemens Lang)
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch Cc:
Port:

Description

bitbucket.setup sets the port name to the project name.

This causes troubles if the instruction is used inside a subport, namely the subport is not found by 'port'.

The solution would be to conditionally set name only when bitbucket.setup is not used in a subport, since the subport name is already set.

See: #40831

Attachments (1)

bitbucket-1.0.tcl.diff​ (1.0 KB) - added by nortcele 6 years ago.

Download all attachments as: .zip

Change History (6)

Changed 6 years ago by nortcele

Attachment: bitbucket-1.0.tcl.diff​ added

comment:1 Changed 6 years ago by mf2k (Frank Schima)

Keywords: haspatch added; bitbucket portgroup removed
Type: defect → enhancement

comment:2 Changed 6 years ago by mf2k (Frank Schima)

Port: bitbucket removed

comment:3 Changed 6 years ago by neverpanic (Clemens Lang)

Owner: set to neverpanic
Resolution: → fixed
Status: new → closed

In fbfa973b2522436a5565f07bc1130c43a86ca033/macports-ports:

bitbucket portgroup: Fix subport behavior

The same problem that affected the github portgroup also exists in the
bitbucket portgroup. Fix it with a siliar patch.

See: #40831
Closes: #55467

comment:4 Changed 6 years ago by neverpanic (Clemens Lang)

Thanks!

comment:5 Changed 2 years ago by catap (Kirill A. Korinsky)

In 7c78e351d6ba6010a127c046ffa0736b8b4e125a/macports-ports (master):

portgroups: respect subport name, when it matches project name

Sometime subport name is matched project name on bitbucket, github,
gitlab, etc. Let stop to overwrite name for this case.

See: #40831
See: #55467

Note: See TracTickets for help on using tickets.