libuv @1.18.0 does not build on PPC Tiger because configure does not determine that unsetenv() is a void function?

[ballapete (Peter "Pete" Dyballa)]

Executing:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_lil.fr.rsync.macports.org_release_tarballs_ports_devel_libuv/libuv/work/libuv-1.18.0" && /usr/bin/make -w all 
DEBUG: system:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_lil.fr.rsync.macports.org_release_tarballs_ports_devel_libuv/libuv/work/libuv-1.18.0" && /usr/bin/make -w all 
make: Entering directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_lil.fr.rsync.macports.org_release_tarballs_ports_devel_libuv/libuv/work/libuv-1.18.0'
  CC       src/libuv_la-fs-poll.lo
  CC       src/libuv_la-inet.lo
  CC       src/libuv_la-threadpool.lo
  CC       src/libuv_la-uv-common.lo
  CC       src/libuv_la-version.lo
  CC       src/unix/libuv_la-async.lo
  CC       src/unix/libuv_la-core.lo
src/unix/core.c: In function 'uv_os_unsetenv':
src/unix/core.c:1306: error: void value not ignored as it ought to be
make: *** [src/unix/libuv_la-core.lo] Error 1
make: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_lil.fr.rsync.macports.org_release_tarballs_ports_devel_libuv/libuv/work/libuv-1.18.0'
Command failed:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_lil.fr.rsync.macports.org_release_tarballs_ports_devel_libuv/libuv/work/libuv-1.18.0" && /usr/bin/make -w all 
Exit code: 2

core.c has:

 1302	int uv_os_unsetenv(const char* name) {
 1303	  if (name == NULL)
 1304	    return -EINVAL;
 1305	
 1306	  if (unsetenv(name) != 0)
 1307	    return -errno;
 1308	
 1309	  return 0;
 1310	}

Couldn't it just return 0?

[ballapete (Peter "Pete" Dyballa)]

main.log from PPC Tiger

[ballapete (Peter "Pete" Dyballa)]

libuv-devel has exactly the same failure.

[kencu (Ken)]

this is essentially the same isssue as the cmake 3.10 build failure on Tiger we are working on, which also fails building libuv.

[kencu (Ken)]

I think I mostly have this licked, except for a few test failures I see on 10.4 that I don't see elsewhere, that I would like to fix

$ port -v installed libuv
The following ports are currently installed:
  libuv @1.23.2_0 (active) platform='darwin 8' archs='ppc' date='2018-11-10T14:34:56-0800'

You can get the current work at <​https://github.com/kencu/TigerPorts/>. If you can help me fix the test failures as well, that would be nice!

[ken-cunningham-webuse]

In a5060dcfd1925b3e8921fb99e4c40568ab19b16b/macports-ports (master):

libuv: peg at 1.23.2 for Tiger

with patches for Tiger that use existing fallback routines written into libuv
passes 98% of test suite, fulfils needs of many ports (eg cmake)
set up to not interfere with existing libuv port
closes: #55594