Opened 3 years ago

Closed 3 years ago

#55706 closed defect (fixed)

gle-graphics @4.2.5: build failure under 10.13

Reported by: majoc-at-astro (majoc-at-astro) Owned by: ryandesign (Ryan Schmidt)
Priority: Normal Milestone:
Component: ports Version: 2.4.2
Keywords: Cc:
Port: gle-graphics

Description

clang++ seems to get mightily confused when compiling ffitcontour.cpp; please see enclosed logfile.

macOS 10.13.2

  • BuildVersion: 17C205

Xcode 9.2

  • Xcode: Build version 9C40b
  • clang: Apple LLVM version 9.0.0 (clang-900.0.39.2)

Attachments (1)

gle-graphics.log.2018-01-15_10.46.19 (112.7 KB) - added by majoc-at-astro (majoc-at-astro) 3 years ago.

Download all attachments as: .zip

Change History (4)

Changed 3 years ago by majoc-at-astro (majoc-at-astro)

comment:1 Changed 3 years ago by ryandesign (Ryan Schmidt)

Confirmed on Sierra with Xcode 9.2. It built successfully on Sierra on 2017-04-24 with whatever version of Xcode we had installed on the buildbot worker at that time.

The code in question is... terrible...

comment:2 in reply to:  1 Changed 3 years ago by ryandesign (Ryan Schmidt)

Owner: set to ryandesign
Status: newaccepted

Replying to ryandesign:

The code in question is... terrible...

It was converted programmatically from FORTRAN to C in 1990. It's a wonder it's been working this long.

Fortunately it seems they ran into this problem on OS2 and Windows before, and the same fix works on macOS now.

comment:3 Changed 3 years ago by ryandesign (Ryan Schmidt)

Resolution: fixed
Status: acceptedclosed

In a0d07b9f3cb38f842f4561656b16812d2d247191/macports-ports:

gle-graphics: Avoid redefining abs on macOS too

Closes: #55706

Note: See TracTickets for help on using tickets.