Opened 6 years ago

Closed 6 years ago

#55808 closed submission (fixed)

Submission of new port aidadoc

Reported by: bdesgraupes Owned by: Bernard Desgraupes <bdesgraupes@…>
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc: mojca (Mojca Miklavec)
Port: aidadoc

Attachments (3)

Portfile (1.6 KB) - added by bdesgraupes 6 years ago.
Portfile.2 (1.5 KB) - added by bdesgraupes 6 years ago.
Portfile.3 (1.8 KB) - added by mojca (Mojca Miklavec) 6 years ago.

Download all attachments as: .zip

Change History (12)

Changed 6 years ago by bdesgraupes

Attachment: Portfile added

comment:1 Changed 6 years ago by mojca (Mojca Miklavec)

maintainers             users.sourceforge.net:bdesgraupes

Please add your github handle and please check our guide for description of how openmaintainer works. The line could become:

maintainers             {@bdesgraupes users.sourceforge.net:bdesgraupes} openmaintainer
use_parallel_build      yes

Isn't parallel building default already?

extract.suffix          -src.tar.bz2

This looks like a bad idea to me. You should change $distname instead:

distname ${name}-${version}-src

The checksums should contain rmd160 and sha256. If you have just one file, there's no need to provide its name.

The pre-configure step should probably be done with some variation of use_autoconf yes and perhaps setting autoconf.cmd.

comment:2 Changed 6 years ago by mojca (Mojca Miklavec)

Cc: mojca added

comment:3 Changed 6 years ago by mojca (Mojca Miklavec)

Keywords: haspatch added

comment:4 Changed 6 years ago by mf2k (Frank Schima)

Description: modified (diff)
Keywords: haspatch removed

FYI, the "haspatch" keyword is redundant for a submission port and, hence, not needed. Otherwise it would be a request. :)

Last edited 6 years ago by mf2k (Frank Schima) (previous) (diff)

comment:5 Changed 6 years ago by mf2k (Frank Schima)

Description: modified (diff)

Changed 6 years ago by bdesgraupes

Attachment: Portfile.2 added

comment:6 Changed 6 years ago by bdesgraupes

I have made the recommended fixes and have just been attaching the modified Portfile (added as Portfile.2).

comment:7 Changed 6 years ago by mojca (Mojca Miklavec)

You should not use tabs, only spaces, but I have a few more comments to follow.

system "cd ${build.dir}; autoheader;"

can better be done with something like

system -W ${build.dir} autoheader
Last edited 6 years ago by mojca (Mojca Miklavec) (previous) (diff)

comment:8 Changed 6 years ago by mojca (Mojca Miklavec)

I'm attaching the file I would commit. The problem is that I cannot make the download work.

One further comment: you removed some checksums, I later noticed that SF publishes some checksums like the ones you initially wrote; in those cases it's ok to include some more checksums (that is: those which are published), but rmd160 and sha256 are "mandatory".

Changed 6 years ago by mojca (Mojca Miklavec)

Attachment: Portfile.3 added

comment:9 Changed 6 years ago by Bernard Desgraupes <bdesgraupes@…>

Owner: set to Bernard Desgraupes <bdesgraupes@…>
Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.