Changes between Initial Version and Version 1 of Ticket #55847, comment 3


Ignore:
Timestamp:
Mar 1, 2018, 5:54:10 AM (6 years ago)
Author:
ryandesign (Ryan Carsten Schmidt)
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #55847, comment 3

    initial v1  
    1 That's simple enough to fix. They're checking whether a pointer (`aFileId`) is less than zero. Pointers shouldn't be compared in that way. It should instead be checked whether the pointer is `nil`.
     1That's simple enough to fix. They're checking whether a pointer (`aFileId`) is less than zero. Pointers shouldn't be compared in that way. It should instead be checked whether the pointer is `NULL`.
    22
    33A change to this code was already [https://github.com/FreeCAD/FreeCAD/commit/666a3e5a6850264da5048b0a257a1bc591ce5780 committed] but I haven't tested whether it fixes the problem.