freecad: Update to 0.16.6712

[ryandesign (Ryan Carsten Schmidt)]

This Backport release contains bug fixes and/or security patches over the original 0.16.xxxx release.

[Schamschula (Marius Schamschula)]

I'm aware of this update. I tried building this version about one month ago. However, it fails to build with the same error as in #55840

[Schamschula (Marius Schamschula)]

This update fixes the cmake issue.

However, the build fails @

:info:build [ 24%] Building CXX object src/3rdParty/salomesmesh/CMakeFiles/DriverDAT.dir/src/DriverDAT/DriverDAT_W_SMDS_Mesh.cpp.o
:info:build cd /opt/local/var/macports/build/_Users_marius_Development_MacPorts_ports_cad_freecad/freecad/work/build/src/3rdParty/salomesmesh && /usr/bin/clang++  -DCSFDB -DDriverDAT_EXPORTS -DHAVE_CONFIG_H -DHAVE_LIMITS_H -DLIN -DOCC_CONVERT_SIGNALS -DQT_CORE_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_NO_DEBUG -DQT_OPENGL_LIB -DQT_SVG_LIB -DQT_UITOOLS_LIB -DQT_WEBKIT_LIB -DQT_XML_LIB -D_OCC64 -I/opt/local/var/macports/build/_Users_marius_Development_MacPorts_ports_cad_freecad/freecad/work/build -isystem /opt/local/libexec/qt4/include -isystem /opt/local/libexec/qt4/include/QtOpenGL -isystem /opt/local/libexec/qt4/include/QtSvg -isystem /opt/local/libexec/qt4/include/QtUiTools -isystem /opt/local/libexec/qt4/include/QtWebKit -isystem /opt/local/libexec/qt4/include/QtGui -isystem /opt/local/libexec/qt4/include/QtXml -isystem /opt/local/libexec/qt4/include/QtNetwork -isystem /opt/local/libexec/qt4/include/QtCore -I/opt/local/var/macports/build/_Users_marius_Development_MacPorts_ports_cad_freecad/freecad/work/build/src -I/opt/local/var/macports/build/_Users_marius_Development_MacPorts_ports_cad_freecad/freecad/work/FreeCAD-0.16.6712/src -I/opt/local/var/macports/build/_Users_marius_Development_MacPorts_ports_cad_freecad/freecad/work/FreeCAD-0.16.6712/src/3rdParty/salomesmesh/src/SMDS -I/opt/local/var/macports/build/_Users_marius_Development_MacPorts_ports_cad_freecad/freecad/work/FreeCAD-0.16.6712/src/3rdParty/salomesmesh/src/Driver -I/opt/local/var/macports/build/_Users_marius_Development_MacPorts_ports_cad_freecad/freecad/work/FreeCAD-0.16.6712/src/3rdParty/salomesmesh/src/DriverUNV -I/opt/local/var/macports/build/_Users_marius_Development_MacPorts_ports_cad_freecad/freecad/work/FreeCAD-0.16.6712/src/3rdParty/salomesmesh/src/DriverDAT -I/opt/local/var/macports/build/_Users_marius_Development_MacPorts_ports_cad_freecad/freecad/work/FreeCAD-0.16.6712/src/3rdParty/salomesmesh/src/DriverSTL -I/opt/local/var/macports/build/_Users_marius_Development_MacPorts_ports_cad_freecad/freecad/work/FreeCAD-0.16.6712/src/3rdParty/salomesmesh/src/StdMeshers -I/opt/local/var/macports/build/_Users_marius_Development_MacPorts_ports_cad_freecad/freecad/work/FreeCAD-0.16.6712/src/3rdParty/salomesmesh/inc -I/opt/local/var/macports/build/_Users_marius_Development_MacPorts_ports_cad_freecad/freecad/work/build/src/3rdParty/salomesmesh -I/opt/local/include -I/opt/local/include/oce  -Wall -Wno-deprecated -Wno-write-strings -pipe -Os -stdlib=libc++ -std=c++11 -D_OCC64 -Wno-sign-compare -Wno-reorder -Wno-switch -Wno-unused-variable -Wno-unused-private-field -Wno-unused-function -Wno-sometimes-uninitialized -Wno-overloaded-virtual -Wno-dynamic-class-memaccess -Wno-comment -Wno-self-assign -Wno-reorder -Wno-switch-enum -Wno-unknown-pragmas -Wno-logical-op-parentheses -Wno-unused-variable -Wno-unused-function -Wno-overloaded-virtual -DNDEBUG -arch x86_64 -mmacosx-version-min=10.13 -fPIC   -o CMakeFiles/DriverDAT.dir/src/DriverDAT/DriverDAT_W_SMDS_Mesh.cpp.o -c /opt/local/var/macports/build/_Users_marius_Development_MacPorts_ports_cad_freecad/freecad/work/FreeCAD-0.16.6712/src/3rdParty/salomesmesh/src/DriverDAT/DriverDAT_W_SMDS_Mesh.cpp
:info:build In file included from /opt/local/var/macports/build/_Users_marius_Development_MacPorts_ports_cad_freecad/freecad/work/FreeCAD-0.16.6712/src/Base/Reader.cpp:42:
:info:build In file included from /opt/local/var/macports/build/_Users_marius_Development_MacPorts_ports_cad_freecad/freecad/work/FreeCAD-0.16.6712/src/Base/Sequencer.h:29:
:info:build In file included from /opt/local/var/macports/build/_Users_marius_Development_MacPorts_ports_cad_freecad/freecad/work/FreeCAD-0.16.6712/src/CXX/Extensions.hxx:40:
:info:build In file included from /opt/local/var/macports/build/_Users_marius_Development_MacPorts_ports_cad_freecad/freecad/work/FreeCAD-0.16.6712/src/CXX/Python2/Extensions.hxx:186:
:info:build /opt/local/var/macports/build/_Users_marius_Development_MacPorts_ports_cad_freecad/freecad/work/FreeCAD-0.16.6712/src/CXX/Python2/ExtensionType.hxx:128:13: warning: 'delete' applied to a pointer that was allocated with 'new[]'; did you mean 'delete[]'? [-Wmismatched-new-delete]
:info:build             delete m_methods_table;
:info:build             ^
:info:build                   []
:info:build /opt/local/var/macports/build/_Users_marius_Development_MacPorts_ports_cad_freecad/freecad/work/FreeCAD-0.16.6712/src/CXX/Python2/ExtensionType.hxx:120:28: note: allocated with 'new[]' here
:info:build         : m_methods_table( new PyMethodDef[ METHOD_TABLE_SIZE_INCREMENT ] )
:info:build                            ^
:info:build /opt/local/var/macports/build/_Users_marius_Development_MacPorts_ports_cad_freecad/freecad/work/FreeCAD-0.16.6712/src/3rdParty/salomesmesh/src/DriverDAT/DriverDAT_R_SMDS_Mesh.cpp:55:15: error: ordered comparison between pointer and zero ('FILE *' (aka '__sFILE *') and 'int')
:info:build   if (aFileId < 0) {
:info:build       ~~~~~~~ ^ ~
:info:build 1 error generated.
:info:build make[2]: *** [src/3rdParty/salomesmesh/CMakeFiles/DriverDAT.dir/src/DriverDAT/DriverDAT_R_SMDS_Mesh.cpp.o] Error 1

[ryandesign (Ryan Carsten Schmidt)]

That's simple enough to fix. They're checking whether a pointer (aFileId) is less than zero. Pointers shouldn't be compared in that way. It should instead be checked whether the pointer is NULL.

A change to this code was already ​committed but I haven't tested whether it fixes the problem.

[ryandesign (Ryan Carsten Schmidt)]

​https://github.com/macports/macports-ports/pull/1362

[Ryan Schmidt <git@…>]

In 3441e8eefa0d0ab05a764160d1b168b6a310be62/macports-ports:

FreeCAD: Update to 0.16.6712

Closes: #55847