Opened 3 years ago

Closed 21 months ago

Last modified 21 months ago

#55907 closed defect (fixed)

x264 @20171225: reinplace s|-falign-loops=16||g didn't change anything

Reported by: gaming-hacker (G Alexander) Owned by: dbevans (David B. Evans)
Priority: Normal Milestone:
Component: ports Version: 2.4.2
Keywords: Cc:
Port: x264

Description

building this port with variant +10 produces the following on travis with xcode9.2, osx10.12

 sudo port -N install x264 +high10
--->  Computing dependencies for x264
--->  Dependencies to be installed: nasm
--->  Fetching archive for nasm
--->  Attempting to fetch nasm-2.13.03_0.darwin_16.x86_64.tbz2 from https://packages.macports.org/nasm
--->  Attempting to fetch nasm-2.13.03_0.darwin_16.x86_64.tbz2.rmd160 from https://packages.macports.org/nasm
--->  Installing nasm @2.13.03_0
--->  Activating nasm @2.13.03_0
--->  Cleaning nasm
--->  Fetching archive for x264
--->  Attempting to fetch x264-20171225_0+high10.darwin_16.x86_64.tbz2 from https://packages.macports.org/x264
--->  Attempting to fetch x264-20171225_0+high10.darwin_16.x86_64.tbz2 from http://ywg.ca.packages.macports.org/mirror/macports/packages/x264
--->  Attempting to fetch x264-20171225_0+high10.darwin_16.x86_64.tbz2 from http://mse.uk.packages.macports.org/sites/packages.macports.org/x264
--->  Fetching distfiles for x264
--->  Attempting to fetch x264-snapshot-20171225-2245-stable.tar.bz2 from https://distfiles.macports.org/x264
--->  Verifying checksums for x264
--->  Extracting x264
Warning: reinplace s|-falign-loops=16||g didn't change anything in /opt/local/var/macports/build/_opt_local_var_macports_sources_distfiles.macports.org_ports_multimedia_x264/x264/work/x264-snapshot-20171225-2245-stable/configure
--->  Configuring x264
--->  Building x264
--->  Staging x264 into destroot
--->  Installing x264 @20171225_0+high10
--->  Activating x264 @20171225_0+high10
--->  Cleaning x264
--->  Updating database of binaries
--->  Scanning binaries for linking errors
--->  No broken files found.

Change History (3)

comment:1 Changed 3 years ago by ryandesign (Ryan Schmidt)

Cc: dbevans removed
Keywords: regex removed
Owner: set to dbevans
Status: newassigned
Summary: x264, bad regex?x264 @20171225: reinplace s|-falign-loops=16||g didn't change anything
Type: updatedefect

comment:2 Changed 21 months ago by dbevans (David B. Evans)

Resolution: fixed
Status: assignedclosed

In 8a133c046e96148a476dcf7fe14c9af5258fa327/macports-ports (master):

x264: update to latest stable build 155

ABI incompatible with previous build 152.
Remove +high10 variant, now supports both 8 and 10 bit pixel depths by default.
Remove do-nothing reinplace.

Fixes #55907

comment:3 in reply to:  2 Changed 21 months ago by l2dy (Zero King)

Replying to dbevans:

In 8a133c046e96148a476dcf7fe14c9af5258fa327/macports-ports (master):

x264: update to latest stable build 155

ABI incompatible with previous build 152.
Remove +high10 variant, now supports both 8 and 10 bit pixel depths by default.
Remove do-nothing reinplace.

Fixes #55907

Also API incompatible, e.g. in libVLC:

codec/x264.c:850:26: error: use of undeclared identifier 'x264_bit_depth'
        const int mask = x264_bit_depth > 8 ? X264_CSP_HIGH_DEPTH : 0;
Note: See TracTickets for help on using tickets.