Opened 2 years ago

Last modified 8 months ago

#55915 assigned defect

mariadb-10.2 @10.2.12: clang: error: unknown argument: '-fwhole-program'

Reported by: ryandesign (Ryan Schmidt) Owned by: michaelld (Michael Dickens)
Priority: Normal Milestone:
Component: ports Version:
Keywords: mavericks Cc:
Port: mariadb-10.2

Description

mariadb-10.2 fails to build on Mavericks because its version of clang (Apple LLVM version 6.0 (clang-600.0.57) (based on LLVM 3.5svn)) is too old to understand the -fwhole-program flag that mariadb's build system uses.

https://build.macports.org/builders/ports-10.9_x86_64-builder/builds/49701

I'm not sure when this flag was introduced into clang but the build succeeds on Yosemite with its clang (Apple LLVM version 7.0.2 (clang-700.1.81)).

Change History (7)

comment:1 Changed 2 years ago by ryandesign (Ryan Schmidt)

I did some more research and filed an upstream bug report:

https://jira.mariadb.org/browse/MDEV-15435

It appears that -fwhole-program is completely pointless for us. New versions of clang ignore it (they print a warning that the option is not supported), while old versions error out. We could probably just remove the flag.

I'm not clear why we don't see the same error with mariadb-10.1, which contains the flag too. Maybe the particular subsection of the build that involves this flag is off by default on 10.1 but on by default on 10.2.

comment:2 Changed 17 months ago by mf2k (Frank Schima)

Owner: pixilla deleted
Status: newassigned

See #57827

comment:3 Changed 16 months ago by michaelld (Michael Dickens)

Is this still an issue with the recent MDB 10.2 update?

comment:4 Changed 16 months ago by michaelld (Michael Dickens)

Owner: set to michaelld

comment:5 Changed 8 months ago by michaelld (Michael Dickens)

Is this still an issue with the update of MariaDB 10.2 to 10.2.28 on Nov 5? ​[32c03448aa4061acc3ad5676fa84a834098b0615/macports-ports]

Last edited 8 months ago by ryandesign (Ryan Schmidt) (previous) (diff)

comment:6 Changed 8 months ago by ryandesign (Ryan Schmidt)

You can check by consulting the port health indicators at https://ports.macports.org/port/mariadb-10.2/summary . Unfortunately they don't indicate which version of the port they are for, so you have to click into the details and look. The buildbot is currently busy building the py-tensorflow ports; that can take up to 12 hours, so check back tomorrow to see how mariadb-10.2 @10.2.28 did.

Last edited 8 months ago by ryandesign (Ryan Schmidt) (previous) (diff)

comment:7 Changed 8 months ago by michaelld (Michael Dickens)

That's very cool! Thanks! I didn't know about that specific interface ... maybe I've been told & since I don't use it often enough it's off my radar ... hmnmm .. have to find a way to bookmark it & use it!

The current mariadb-10.2 builds are still from before yesterday's fixes ... and i just pushed a stealth update tweak ... so, I'll (try to remember to) check back tomorrow morning & see what the status is.

Note: See TracTickets for help on using tickets.