Opened 6 years ago
Closed 5 years ago
#55935 closed defect (fixed)
mpbb: buildbot doesn't rebuild port if only supported_archs change
| Reported by: | ryandesign (Ryan Carsten Schmidt) | Owned by: | admin@… |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | buildbot/mpbb | Version: | |
| Keywords: | mpbb | Cc: | |
| Port: |
Description
Suppose a port is committed that is not architecture specific, but it was not marked as such, so as far as MacPorts knows, it's building for a specific architecture, which is indicated in the archive filename. This happened with Sophus in [31e40d2a7216adc42c6242a1de25990154a5a945/macports-ports]. The buildbot builds the port and, if it's distributable, uploads the archive to the packages server. The archive filename is "Sophus-1.0.0_0.darwin_17.x86_64.tbz2".
Then the problem is noticed and supported_archs noarch is added to the portfile. This happened with Sophus in [130ce6ffc708e7a2b31a6f80abc6b739d5cdadb9/macports-ports]. This changes the archive filename to "Sophus-1.0.0_0.darwin_17.noarch.tbz2". My expectation is that the buildbot should rebuild this port and distribute the new archive, since its name has changed. But it doesn't. It notices that the port is already installed at that version, and does nothing.
I manually deleted the wrong archives from the packages server and manually uninstalled the Sophus port on the buildbot workers, then forced a build of the port via the buildbot web interface to get it to build the right archives. This kind of manual intervention shouldn't be necessary.
Change History (1)
comment:1 Changed 5 years ago by ryandesign (Ryan Carsten Schmidt)
| Component: | contrib → buildbot/mpbb |
|---|---|
| Owner: | set to admin@… |
| Resolution: | → fixed |
| Status: | new → closed |
I think this has been fixed by [6ac8fd431e21ab558fdbe3d4c4f74613889142ed/mpbb] as of which it no longer cares whether the archive is installed on the worker but instead checks whether the archive is already on the server. Since changing a port to or from noarch will changes its archive name, this would result in the port now being correctly scheduled for a new build.