Opened 3 years ago

Closed 3 years ago

#56087 closed defect (fixed)

ntpsec @1.1.0: broken for macOS <10.13

Reported by: fhgwright (Fred Wright) Owned by: lbschenkel (Leonardo Brondani Schenkel)
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc:
Port: ntpsec

Description

Between the 1.0.0 release and the 1.1.0 release, ntpsec reduced Mac compatibility further such that it no longer builds on 10.12 (though this isn't reflected in the Portfile). I'm currently testing a fix for this, adapted from already working code in my own ntpsec repo.

Change History (9)

comment:1 Changed 3 years ago by lbschenkel (Leonardo Brondani Schenkel)

Thanks. Unfortunately I only have a 10.13 machine to test, so I did not catch this. I also find it strange that I didn't get a mail from the buildbot notifying the failure on 10.12.

comment:2 Changed 3 years ago by mf2k (Frank Schima)

Cc: lbschenkel removed
Owner: set to lbschenkel
Status: newassigned

comment:3 Changed 3 years ago by ryandesign (Ryan Schmidt)

Many developers don't receive buildbot emails at this time, for reasons that have not yet been determined; see #56045.

comment:4 Changed 3 years ago by ryandesign (Ryan Schmidt)

The developer of ntpsec is hostile toward macOS and is not interested in providing support for earlier versions of macOS that do not have features he wants to use in his software.

comment:5 in reply to:  4 Changed 3 years ago by fhgwright (Fred Wright)

Replying to ryandesign:

The developer of ntpsec is hostile toward macOS and is not interested in providing support for earlier versions of macOS that do not have features he wants to use in his software.

Yeah, I know. :-) As seen here:

cc9491c82 Drop support for OS X 10.11.  Apple screwed this pooch too many different ways.

Though that was actually based on taking a wrong approach to fixing code that was broken in multiple ways, anyway.

Supporting ntpsec on the Mac may eventually become intractable, but for now it's not *that* hard to fix, by reverting the two commits that broke 10.12, and adding a few additional patches for <10.12. Since the 10.12 and <10.12 patches touch at least one common file, I didn't split them into separate patchfiles.

comment:6 Changed 3 years ago by fhgwright (Fred Wright)

I finally had time to test this adequately, and opened a PR for it:

https://github.com/macports/macports-ports/pull/1470

Travis tests have passed.

comment:7 Changed 3 years ago by lbschenkel (Leonardo Brondani Schenkel)

I have seen it and I'm concerned about the size of the patch. Subsequent discussion about the PR itself and its size will happen there.

comment:8 Changed 3 years ago by lbschenkel (Leonardo Brondani Schenkel)

Actually it seems that the PR is not the best place for discussion. :-) I'm OK to have a bit more 1:1 back-and-forth here before involving the list, in case you prefer that way.

After I wrote my comment in the PR, I had an idea. My suggestion is that you split the patch in 2: (1) the minimal one that builds in macOS 10.2, and (2) the minimal one for older systems (which I presume is on top of, or includes, the other one). We may have a clearer picture on how to move forward once we can see those separated.

P.S.: I'm impressed about the effort you put into this. You seem very invested into making NTPsec work well on macOS. If I'm right, would you be interested in taking over ownership of this port, or being a co-maintainer? I added NTPsec port to MacPorts because I strongly support the goals of the upstream project, and I wanted to use it as a replacement for NTP, but I was unaware about how little they care about having it work well on macOS. My interest has faded since then. Actually this might be the only port I maintain that I'm not actively using, which is something I don't do in general, but I didn't want to leave this orphaned. You look to me as somebody who could be a much better maintainer for this port than I am.

Last edited 3 years ago by lbschenkel (Leonardo Brondani Schenkel) (previous) (diff)

comment:9 Changed 3 years ago by fhgwright (Fred Wright)

Resolution: fixed
Status: assignedclosed

In 31b309b046489c03e5f9d1199e5de4f90916d50a/macports-ports:

ntpsec: Fixes build for macOS <10.13.

The 1.1.0 release of ntpsec included further desupport of macOS
such that it no longer builds on 10.12. This change adds a patch
which reverts the offending changes, as well as making a few
additional changes to allow building on earlier OSX versions.

This code is also visible (for now) at:

https://gitlab.com/fhgwright/ntpsec/tree/NTPsec_1_1_0_macports

which is derived from:

https://gitlab.com/fhgwright/ntpsec/tree/NTPsec_1_1_0_fw

by excluding unnecessary changes for this context.

TESTED:
Built and ran on MacPro 10.9, PowerBook 10.5, and VMs for 10.5-10.13.

Closes: #56087

Also adds author as maintainer.

Note: See TracTickets for help on using tickets.