webkit2-gtk @2.14.2_2+quartz: fails to build under 10.13.4

[aque (Allan Que)]

Getting the following Symbol not found error. I ran the build again after a sudo port clean webkit2-gtk and got the same result. This is with macOS 10.13.4 17E199 Xcode 9.3 9E145.

:info:build dyld: Symbol not found: __cg_jpeg_resync_to_restart
:info:build   Referenced from: /System/Library/Frameworks/ImageIO.framework/Versions/A/ImageIO
:info:build   Expected in: /opt/local/lib/libjpeg.9.dylib
:info:build  in /System/Library/Frameworks/ImageIO.framework/Versions/A/ImageIO
:info:build Command '[u'/opt/local/var/macports/build/_opt_local_var_macports_sources_github.com_macports-ports_www_webkit2-gtk/webkit2-gtk/work/build/Source/WebKit2/tmp-introspectaVfwn1/WebKit2-4.0', u'--introspect-dump=/opt/local/var/macports/build/_opt_local_var_macports_sources_github.com_macports-ports_www_webkit2-gtk/webkit2-gtk/work/build/Source/WebKit2/tmp-introspectaVfwn1/functions.txt,/opt/local/var/macports/build/_opt_local_var_macports_sources_github.com_macports-ports_www_webkit2-gtk/webkit2-gtk/work/build/Source/WebKit2/tmp-introspectaVfwn1/dump.xml']' returned non-zero exit status -6
:info:build make[2]: *** [WebKit2-4.0.gir] Error 1

[ryandesign (Ryan Carsten Schmidt)]

We've seen this dyld: Symbol not found: __cg_jpeg_resync_to_restart error many times before (e.g. #36621), but not with webkit2-gtk, and it's usually been because DYLD_LIBRARY_PATH was set to an incorrect value. I see two instances of DYLD_LIBRARY_PATH being set in the log, but the value it's being set to looks ok to me (specifically, it doesn't contain /opt/local/lib).

[MarcusCalhoun-Lopez (Marcus Calhoun-Lopez)]

Following the advice in #39598, setting

configure.args-append \
    -DENABLE_INTROSPECTION=OFF

allowed the port to build.

[MarcusCalhoun-Lopez (Marcus Calhoun-Lopez)]

As far as I can tell, this problem is:

• webkit2-gtk ​runs g-ir-scanner with -L${prefix}/lib
• Not surprisingly, g-ir-scanner passes -L... ​to the compiler
• Somewhat surprisingly, g-ir-scanner also ​appends the directory to DYLD_LIBRARY_PATH
• The use of DYLD_LIBRARY_PATH is a somewhat ​recent addition, and the developers seem to believe it be important

I would humbly submit that a solution might be to replace DYLD_LIBRARY_PATH with DYLD_FALLBACK_LIBRARY_PATH in gobject-introspection.

[MarcusCalhoun-Lopez (Marcus Calhoun-Lopez)]

Upstream Issue Report: ​https://gitlab.gnome.org/GNOME/gobject-introspection/issues/205

[MarcusCalhoun-Lopez (Marcus Calhoun-Lopez)]

In 13dccb148eb91986257f147c433fbf9019ebb0fa/macports-ports (master):

gobject-introspection: avoid using DYLD_LIBRARY_PATH

See ​https://gitlab.gnome.org/GNOME/gobject-introspection/issues/205
Fixes #56301