Opened 6 years ago

Closed 6 years ago

#56433 closed update (fixed)

update gmt4 to 4.5.17

Reported by: fvaccari Owned by: tenomoto (Takeshi Enomoto)
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc:
Port: gmt4

Description

Would it be possible to update gmt4 to version 4.5.17? Currently available version in MacPorts is 4.5.15, and has a serious issue with pscontour, already reported to gmt developers and corrected by them in 4.5.17.

Thanks

Franco

Change History (9)

comment:1 Changed 6 years ago by pmetzger (Perry E. Metzger)

FYI, you may find that the update happens quicker if you submit a GitHub pull request for the needed change to the Portfile.

comment:2 Changed 6 years ago by mf2k (Frank Schima)

Cc: takeshi@… removed
Owner: set to tenomoto
Status: newassigned
Version: 2.4.3

comment:3 Changed 6 years ago by fvaccari

Wasn't aware of the pull request way. Spent half a day to make a proper one, hope didn't make too many formal mistakes...

https://github.com/fvaccari/macports-ports/pull/1

comment:4 Changed 6 years ago by mf2k (Frank Schima)

That's against your personal repository. You have to make the pull against the Macports repository. See wiki:WorkingWithGit.

comment:5 Changed 6 years ago by fvaccari

That wiki entry is describing git operations through Terminal, but I acted through the Web Interface. There was still a green button to be pushed there, and I think I've now completed the pull request choosing the "Rebase and commit" option, that I've read somewhere was the preferred one. It now says

Pull request successfully merged and closed
You’re all set—the fvaccari-patch-1 branch can be safely deleted.

I hope I did it right...

comment:6 Changed 6 years ago by mf2k (Frank Schima)

You have merged it with your personal repository. That has nothing to do with the Macports one.

comment:7 Changed 6 years ago by pmetzger (Perry E. Metzger)

fvaccari, go to the macports repo and click on "new pull request": https://github.com/macports/macports-ports

comment:8 Changed 6 years ago by fvaccari

Eh, https://github.com/macports/macports-ports is where I started from... I thought I did it, but apparently it's not the case. I had the best intentions to give back to MacPorts with this first (insignificant) contribution, but it looks like it's already beyond my capabilities. Will try to learn more, in due time.

Version 0, edited 6 years ago by fvaccari (next)

comment:9 Changed 6 years ago by tenomoto (Takeshi Enomoto)

Resolution: fixed
Status: assignedclosed

In 5930d4c5aa4888744d3c27203380ea8d6cb151f0/macports-ports (master):

gmt4: update to 4.5.18

Closes: #56433

Note: See TracTickets for help on using tickets.