Opened 3 years ago

Closed 3 years ago

#56488 closed update (fixed)

tao @ 6.4.8 (2.4.8) New version available

Reported by: lockhart (Thomas Lockhart) Owned by: ryandesign (Ryan Schmidt)
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch maintainer Cc:
Port: tao

Description

A new version of TAO (and ACE) is available. Some Portfile configuration code inserted many versions ago is removed and checksums are updated.

Attachments (2)

Portfile.diff (1.5 KB) - added by lockhart (Thomas Lockhart) 3 years ago.
Portfile update to version 6.4.8
tao-6.4.8-ryandesign.diff (2.8 KB) - added by ryandesign (Ryan Schmidt) 3 years ago.

Download all attachments as: .zip

Change History (11)

Changed 3 years ago by lockhart (Thomas Lockhart)

Attachment: Portfile.diff added

Portfile update to version 6.4.8

comment:1 in reply to:  description ; Changed 3 years ago by ryandesign (Ryan Schmidt)

Replying to lockhart:

Some Portfile configuration code inserted many versions ago is removed

Why? The upstream code does not seem to have changed, so this is still needed, isn't it?

comment:2 in reply to:  1 ; Changed 3 years ago by lockhart (Thomas Lockhart)

Replying to ryandesign:

Replying to lockhart:

Some Portfile configuration code inserted many versions ago is removed

Why? The upstream code does not seem to have changed, so this is still needed, isn't it?

Nope. It has kept the last few versions from building (which is why you haven't seen Portfile updates from me), and removing it gets a clean build. Not sure what changed exactly, but way back in the past (possibly 2012 at commit [e80dc83cc13cb90431d1e5874e311855165e898a/macports-ports]) I had to insert it to get a clean build and now it doesn't work. Pretty sure that Bradley didn't write that part of the patch though he was very helpful in getting several ports ironed out for me.

Last edited 3 years ago by ryandesign (Ryan Schmidt) (previous) (diff)

comment:3 in reply to:  2 Changed 3 years ago by ryandesign (Ryan Schmidt)

Replying to lockhart:

It has kept the last few versions from building

From what I can see, in April 2012, Bradley added the CC and CXX build arguments, which seems like it should be enough to get it to use the right compiler, but then in May 2012 you added the reinplaces that you're now removing, which seems to suggest that just setting CC and CXX wasn't enough.

What build error did you encounter when leaving the reinplaces in? I haven't finished building yet on my system...

comment:4 Changed 3 years ago by pmetzger (Perry E. Metzger)

BTW, just FYI, it would be best if you did a GitHub Pull Request for the changes. We now prefer Pull Requests, as it makes it easier to process merging the code into MacPorts.

comment:5 in reply to:  4 Changed 3 years ago by lockhart (Thomas Lockhart)

Replying to pmetzger:

BTW, just FYI, it would be best if you did a GitHub Pull Request for the changes. We now prefer Pull Requests, as it makes it easier to process merging the code into MacPorts.

OK, will do for the next time. Is there a FAQ for how you recommend managing cloned repos vs the reference repo? I wouldn't want to have to keep in sync with upstream through github just to be able to help with a few packages every few months...

comment:6 Changed 3 years ago by ryandesign (Ryan Schmidt)

Owner: set to ryandesign
Status: newaccepted

See WorkingWithGit. But it's also fine to continue submitting patches in Trac if you prefer.

I've now built tao successfully both with and without the reinplaces and the build portion of the main.log is the same. However, without the reinplaces, in the destroot phase, the build system's default compiler is once again used, which we don't want. I recommend removing the reinplaces, and just copying the build phase environment variables and arguments to the destroot phase. The portfile already goes to some semi-convoluted lengths to do that manually for the environment variables and some of the arguments. I've simplified this, and will do another test build before before attaching my revised patch here.

Changed 3 years ago by ryandesign (Ryan Schmidt)

Attachment: tao-6.4.8-ryandesign.diff added

comment:7 Changed 3 years ago by ryandesign (Ryan Schmidt)

The attached patch is my suggestion. It builds for me without tripping the check in UsingTheRightCompiler. If it's ok with you, I'll commit it.

comment:9 Changed 3 years ago by ryandesign (Ryan Schmidt)

Resolution: fixed
Status: acceptedclosed

In ff38a4a30ce71e8b157cb631ed9bb9a43dec5c7f/macports-ports (master):

ace, tao: Update to 6.4.8

Closes: #56488
Closes: #56489

Note: See TracTickets for help on using tickets.