Opened 3 years ago

Closed 3 years ago

Last modified 2 years ago

#56515 closed defect (fixed)

gdal: patchfile does not apply

Reported by: ryandesign (Ryan Schmidt) Owned by: Veence (Vincent)
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc:
Port: gdal

Description

https://build.macports.org/builders/ports-10.8_x86_64_legacy-builder/builds/61000/steps/install-port/logs/stdio

--->  Applying patch-netcdfdataset_cpp.diff
DEBUG: Environment: 
CC_PRINT_OPTIONS='YES'
CC_PRINT_OPTIONS_FILE='/opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_ports_gis_gdal/gdal/work/.CC_PRINT_OPTIONS'
CPATH='/opt/local/include'
LIBRARY_PATH='/opt/local/lib'
MACOSX_DEPLOYMENT_TARGET='10.8'
Executing:  cd "/opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_ports_gis_gdal/gdal/work/gdal-2.3.0" && /usr/bin/patch -p0 < '/opt/bblocal/var/buildworker/ports/build/ports/gis/gdal/files/patch-netcdfdataset_cpp.diff'
DEBUG: system:  cd "/opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_ports_gis_gdal/gdal/work/gdal-2.3.0" && /usr/bin/patch -p0 < '/opt/bblocal/var/buildworker/ports/build/ports/gis/gdal/files/patch-netcdfdataset_cpp.diff'
patching file frmts/netcdf/netcdfdataset.cpp
Hunk #1 FAILED at 4642.
1 out of 1 hunk FAILED -- saving rejects to file frmts/netcdf/netcdfdataset.cpp.rej
Command failed:  cd "/opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_ports_gis_gdal/gdal/work/gdal-2.3.0" && /usr/bin/patch -p0 < '/opt/bblocal/var/buildworker/ports/build/ports/gis/gdal/files/patch-netcdfdataset_cpp.diff'
Exit code: 1

Change History (8)

comment:1 Changed 3 years ago by Veence (Vincent)

The patch is probably obsolete. However, I have not access to a pre-stdc++ environment, so I’m unable to test it. I removed the line which pulled in the patch [afb53b6dbdc3d9803088b167d821fd1f69b96a9c/macports-ports]. Could you try again? Thanks

Last edited 3 years ago by ryandesign (Ryan Schmidt) (previous) (diff)

comment:2 Changed 3 years ago by ryandesign (Ryan Schmidt)

Because you committed a change to the port, the buildbot will automatically try to build it again. You can see its progress in the buildbot waterfall. It may take an hour for the buildbot to get to building gdal, as it is currently busy building other ports.

Assuming the build is successful, you should make another commit to actually delete the patchfile from the files directory.

Next time please use the ticket URL in the commit message, so that the commit can be automatically mentioned in the ticket. See CommitMessages.

comment:3 Changed 3 years ago by Veence (Vincent)

Oh, I just realized that this patch was applied even when netcdf wasn't requested with the corresponding variant, which is a bug. All right, I will monitor the buildbot.

Also, yes, I didn't remove the patch file in case the build would fail. This was deliberate, as well as not closing the ticket as long as I’m not sure it’s fixed.

Thanks Ryan for your constant attention.

comment:4 Changed 3 years ago by Veence (Vincent)

Is this one fixed?

comment:5 Changed 3 years ago by ryandesign (Ryan Schmidt)

Certainly by removing the patchfile, you fixed the problem that the patchfile did not apply. Whether or not the patchfile was still needed I cannot say. But it looks like you added it in order to help pre-C++11 systems, and now that gdal doesn't support pre-C++11 systems anymore, it seems like the patch should no longer be needed.

comment:6 Changed 3 years ago by Veence (Vincent)

Resolution: fixed
Status: assignedclosed

Seems reasonable. Closing this ticket.

comment:7 in reply to:  2 Changed 3 years ago by ryandesign (Ryan Schmidt)

Replying to ryandesign:

Assuming the build is successful, you should make another commit to actually delete the patchfile from the files directory.

Do you want to delete the patchfile?

comment:8 Changed 2 years ago by ryandesign (Ryan Schmidt)

Note: See TracTickets for help on using tickets.