fbthrift: update to 2018.05.28.00

[ryandesign (Ryan Carsten Schmidt)]

I'm trying to. It now uses cmake, and it requires its dependency folly to have been installed with cmake too, and that currently isn't working for me, so more investigation is needed.

[mohd-akram (Mohamed Akram)]

Patch to fix CMake build

[mohd-akram (Mohamed Akram)]

Found the culprit.

In ./work/build/CMakeFiles/CMakeError.log:

Building C object CMakeFiles/cmTC_513c0.dir/CheckSymbolExists.c.o
/usr/bin/clang  -I/opt/local/include  -pipe -Os -DNDEBUG -I/opt/local/include -std=gnu++14 -arch x86_64 -mmacosx-version-min=10.13   -o CMakeFiles/cmTC_513c0.dir/CheckSymbolExists.c.o   -c /opt/local/var/macports/build/_Users_mohamed_.ports_devel_folly/folly/work/build/CMakeFiles/CMakeTmp/CheckSymbolExists.c
error: invalid argument '-std=gnu++14' not allowed with 'C'
make[1]: *** [CMakeFiles/cmTC_513c0.dir/CheckSymbolExists.c.o] Error 1
make: *** [cmTC_513c0/fast] Error 2

File /opt/local/var/macports/build/_Users_mohamed_.ports_devel_folly/folly/work/build/CMakeFiles/CMakeTmp/CheckSymbolExists.c:
/* */
#include <pthread.h>

int main(int argc, char** argv)
{
  (void)argv;
#ifndef pthread_atfork
  return ((int*)(&pthread_atfork))[argc];
#else
  (void)argc;
  return 0;
#endif
}

clang gives an error when passing an invalid -std argument, causing cmake checks to fail, while GCC (tested with gcc-mp-5) treats it as a warning.

The std=gnu++14 argument is added ​here.

I've attached a patch for this that removes that flag for C-based checks.

[mohd-akram (Mohamed Akram)]

In 737c3fceee492c943f787441d10a64afc875fe7b/macports-ports (master):

fbthrift: update to 2018.05.28.00

Removes autoconf related configuration.

Closes: #56572

[ryandesign (Ryan Carsten Schmidt)]

So the patch wasn't needed after all? It was not added in the above commit.

[mohd-akram (Mohamed Akram)]

I wasn't clear. That patch was needed for folly - ​https://github.com/macports/macports-ports/pull/1933.

[ryandesign (Ryan Carsten Schmidt)]

Oh right, sorry. And just to record it here, that got merged in [38a75a7125234b3b8b06e3e2f76db876cac04e53/macports-ports].