ddclient @3.8.3_3 still uses perl5.24 in place of perl5.26 ?

[ladeschale]

My ddclient stopped working with ssl.

After some debugging it points me to the Portfile ​https://github.com/macports/macports-ports/blob/master/net/ddclient/Portfile at line 33/34 looks like where the failure is coming from:

        reinplace "s|\[\r\]$||" ${worksrcpath}/${name}
        reinplace "s|^#!.*/perl.*$|#!${prefix}/bin/perl5.24|" ${worksrcpath}/${name}

Installing of ddclient throw following note at configuring/patching part:

--->  Configuring ddclient
]$||  Patching ddclient: s|[
]$|| didn't change anything in /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_net_ddclient/ddclient/work/ddclient-3.8.3/ddclient
--->  Patching ddclient: s|^#!.*/perl.*$|#!/opt/local/bin/perl5.24|
--->  Building ddclient

For debugging i started with fresh install of macports. Installed Ports are:

  curl-ca-bundle @7.61.0_0 (active)
  ddclient @3.8.3_3 (active)
  gdbm @1.16_0 (active)
  gettext @0.19.8.1_0 (active)
  libiconv @1.15_0 (active)
  libidn @1.35_0 (active)
  ncurses @6.1_0 (active)
  openssl @1.0.2o_1 (active)
  p5.26-io-socket-ssl @2.58.0_0 (active)
  p5.26-mozilla-ca @20180117_0 (active)
  p5.26-net-libidn @0.120.0_5 (active)
  p5.26-net-ssleay @1.850.0_0 (active)
  p5.26-sub-uplevel @0.280.0_0 (active)
  p5.26-test-exception @0.430.0_0 (active)
  p5.26-test-nowarnings @1.40.0_1 (active)
  p5.26-test-warn @0.360.0_0 (active)
  perl5 @5.26.1_0+perl5_26 (active)
  perl5.26 @5.26.2_1 (active)
  readline @7.0.003_1 (active)
  zlib @1.2.11_0 (active)

when i start ddclient it throw:

sudo /opt/local/sbin/ddclient -daemon=0 -debug -verbose -noquiet
sudo: unable to execute /opt/local/sbin/ddclient: No such file or directory

when i install perl5.24 ddclient is working but fall down later cause of missing Perl io-socket-ssl Module for version 24, well

FATAL:    Error loading the Perl module IO::Socket::SSL needed for SSL connect.

[jmroot (Joshua Root)]

Yes, that was missed in [d52392c211739ca19889d774a7e16d9a15756d14/macports-ports].

[mojca (Mojca Miklavec)]

​https://github.com/macports/macports-ports/pull/2317

[mojca (Mojca Miklavec)]

Thanks for spotting this. Testing greatly appreciated.

[ladeschale]

ddclient is up an working again after i applied the patch, thank you.

[mojca (Mojca Miklavec)]

In ceacbd5adfb0a6cecff96c439c4e9ac821f1d0b5/macports-ports (master):

ddclient: fix path to perl

Also add size, move patching from configure to post-patch, remove unused patch.
Closes: #56893