Opened 6 years ago
Closed 5 years ago
#56965 closed defect (fixed)
python35 fails to build _ssl module with libressl-devel
| Reported by: | dubiousjim | Owned by: | jmroot (Joshua Root) |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | |
| Keywords: | Cc: | ||
| Port: | python35 |
Description
I'm using libressl-devel (currently at MacPorts version 2.7.4_0). When building python35 from source (currently at MacPorts version 3.5.6_0, but this issue has been present for a while), the _ssl module fails to build. Applying the attached patch fixes the issue. I don't know whether the patch is appropriate for other versions of libressl, and I suspect it isn't appropriate for openssl. So presumably there should be some conditions checked before applying. But I thought I'd pass the patch on, since it's at least a start.
Attachments (2)
Change History (6)
Changed 6 years ago by dubiousjim
| Attachment: | Modules__ssl.c.diff added |
|---|
comment:1 Changed 6 years ago by mf2k (Frank Schima)
| Cc: | jmroot removed |
|---|---|
| Owner: | set to jmroot |
| Status: | new → assigned |
comment:2 Changed 6 years ago by jmroot (Joshua Root)
comment:3 Changed 6 years ago by dubiousjim
It doesn't affect 3.6. Don't know about 3.7. There are a lot of changes in the _ssl.c file between Python 3.5.6 and 3.6.6, but I've attached what seem to be the changes that may be related to this issue. This was a conscientious but casual effort; I haven't attempted to digest all the code in the _ssl.c file.
Changed 6 years ago by dubiousjim
| Attachment: | 356to366_Modules__ssl.c.diff added |
|---|
comment:4 Changed 5 years ago by jmroot (Joshua Root)
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Does this affect 3.6 or 3.7? Probably worth looking at how upstream fixed it if not.