Changes between Initial Version and Version 1 of Ticket #56991, comment 51


Ignore:
Timestamp:
Sep 22, 2019, 6:22:28 PM (20 months ago)
Author:
kencu (Ken)
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #56991, comment 51

    initial v1  
    1 `libvpx` does it's own internal macOS SDK selecting and does not respect the $SDKROOT env var, and so would need some surgery to obey -- nothing is perfect. Some other ports probably will do the same thing. That's why integrating stuff like this is never as simple as it seems to be.
     1`libvpx` does it's own internal macOS SDK selecting and does not respect $SDKROOT . Some other ports probably will do the same thing. That's why integrating stuff like this is never as simple as it seems to be.  Trivial hack in `configure.sh` for a quick fix, but could do this better in a way that respects $SDKROOT.
     2{{{
     3    x86*-darwin*)
     4-      osx_sdk_dir="$(show_darwin_sdk_path macosx)"
     5+      osx_sdk_dir="$(show_darwin_sdk_path macosx10.13)"
     6      if [ -d "${osx_sdk_dir}" ]; then
     7        add_cflags  "-isysroot ${osx_sdk_dir}"
     8        add_ldflags "-isysroot ${osx_sdk_dir}"
     9      fi
     10}}}