Opened 6 years ago

Closed 5 years ago

Last modified 5 years ago

#57047 closed update (fixed)

virt-viewer @6.0: Update to 7.0, requires spice-gtk 0.35

Reported by: matsimon (Mathieu Simon) Owned by: raimue (Rainer Müller)
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch Cc: danchr (Dan Villiom Podlaski Christiansen)
Port: virt-viewer spice-gtk

Description

Dear port maintainer

I wanted to check out if emulators/virt-viewer 7.0 was possible to get into macports and have tried to come up with a patch. It seems to work for me by connecting to a RHV/oVirt 4.2 cluster by using xorg-server from Macports itself.

The only issue I ran into much later (but will compare with 6.0) is that sending the keys as provided in the GUI for i.e. Ctrl-Alt-Del does not work but does when i.e. sending via keyboard.

virt-viewer 7.0 requires gnome/spice-gtk to be bumped from 0.34 to 0.35 as well in order to build thus I will attach a second patch.

This was tested on macOS 10.13.6, MacPorts 2.5.3 and Xcode 9.4.1

Regards Mathieu

Attachments (2)

emulators_virt-viewer-6.0to7.0.patch (1.4 KB) - added by matsimon (Mathieu Simon) 6 years ago.
virt-viewer 6.0 to 7.0
gnome_spice-gtk-0.34to0.35.patch (1.2 KB) - added by matsimon (Mathieu Simon) 6 years ago.
Update spice-gtk 0.34 to 0.35

Download all attachments as: .zip

Change History (9)

Changed 6 years ago by matsimon (Mathieu Simon)

virt-viewer 6.0 to 7.0

Changed 6 years ago by matsimon (Mathieu Simon)

Update spice-gtk 0.34 to 0.35

comment:1 Changed 6 years ago by mf2k (Frank Schima)

In the future, please add the port maintainer(s) to Cc (port info --maintainers virt-viewer spice-gtk), if any. This should really be 2 tickets, one for each port.

comment:2 Changed 6 years ago by mf2k (Frank Schima)

Cc: danchr added
Owner: set to raimue
Status: newassigned
Version: 2.5.3

comment:3 Changed 6 years ago by mf2k (Frank Schima)

For spice-gtk, the revision line should be removed because it starts at 0 when increasing the version and that is the default value.

comment:4 Changed 5 years ago by frank-f

This patch works like a charm. It's a shame, that no-one has applied it yet, because 6.0 has at least one really annoying bug when switching windows.

comment:5 Changed 5 years ago by raimue (Rainer Müller)

In 731248b54e15b054db1d1b99c789ff53fd4e861a/macports-ports (master):

spice-gtk: Update to version 0.35

See: #57047

comment:6 Changed 5 years ago by raimue (Rainer Müller)

Resolution: fixed
Status: assignedclosed

In f09c6e1744e743fd36cd9ab2abe2dadaa56bc254/macports-ports (master):

virt-viewer: Update to version 7.0

Closes: #57047

comment:7 Changed 5 years ago by raimue (Rainer Müller)

Thank you for the patches! As seen above, I applied them now to the ports tree.

Note: See TracTickets for help on using tickets.