Opened 21 months ago

Last modified 21 months ago

#57109 assigned defect

cquery @20180718 shared_timed_mutex introduced in macOS 10.12

Reported by: rurban (Reini Urban) Owned by: wyuenho (Jimmy Yuen Ho Wong)
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch Cc:
Port: cquery

Description (last modified by rurban (Reini Urban))

cquery-20180718_0.darwin_15 fails to build on darwin 15.6:

cquery-20180718/src/import_manager.h:30:8: error: 'shared_timed_mutex' is unavailable: introduced in macOS 10.12
:info:build   std::shared_timed_mutex dependency_mutex_;
:info:build        ^
:info:build /Applications/
/include/c++/v1/shared_mutex:202:58: note: 'shared_timed_mutex' has been explicitly marked unavailable here

needs to be worked around somehow for older darwin's. attached patch fixe it for me. See also (without fix yet, but they kept working on it)

Attachments (1)

shared_timed_mutex.patch (2.0 KB) - added by rurban (Reini Urban) 21 months ago.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 21 months ago by rurban (Reini Urban)

Changed 21 months ago by rurban (Reini Urban)

Attachment: shared_timed_mutex.patch added

comment:2 Changed 21 months ago by rurban (Reini Urban)

Description: modified (diff)

comment:3 Changed 21 months ago by ryandesign (Ryan Schmidt)

Keywords: haspatch added
Owner: set to wyuenho
Status: newassigned

comment:4 Changed 21 months ago by wyuenho (Jimmy Yuen Ho Wong)

I feel like this patch should be submitted upstream, and guarded by some preprocessor constants so only systems that don't support C++14 will revert back to the slower mutex.

Note: See TracTickets for help on using tickets.