poppler 0.69.0 appears to break texlive-bin

[blair (Blair Zajac)]

$ /opt/local/bin/port -v rev-upgrade
--->  Scanning binaries for linking errors
Could not open /opt/local/lib/libpoppler.79.dylib: Error opening or reading file (referenced from /opt/local/libexec/texlive/binaries/luajittex)
--->  Found 6 broken files, matching files to ports
--->  Found 1 broken port, determining rebuild order
--->  Rebuilding in order
     texlive-bin @2018.47642 +x11

...

/usr/bin/clang++ -DHAVE_CONFIG_H -I. -I./w2c   -I/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_tex_texlive-bin/texlive-bin/work/texlive-source-2018.47642-stripped/texk -I/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_tex_texlive-bin/texlive-bin/work/texlive-source-2018.47642-stripped/texk  -I/opt/local/include/libpng16 -DPOPPLER_VERSION=\"0.69.0\" -I/opt/local/include/poppler -I./libmd5 -I./pdftexdir -isystem/opt/local/include -Wimplicit -Wreturn-type -Wno-unknown-pragmas -Wno-write-strings -pipe -Os -std=c++11 -Wno-reserved-user-defined-literal -stdlib=libc++ -arch x86_64 -MT pdftexdir/libpdftex_a-pdftoepdf.o -MD -MP -MF pdftexdir/.deps/libpdftex_a-pdftoepdf.Tpo -c -o pdftexdir/libpdftex_a-pdftoepdf.o `test -f 'pdftexdir/pdftoepdf.cc' || echo './'`pdftexdir/pdftoepdf.cc
pdftexdir/pdftoepdf.cc:320:20: error: assigning to 'char *' from incompatible type 'const char *'
        key = obj->dictGetKey(i);
              ~~~~~^~~~~~~~~~~~~
pdftexdir/pdftoepdf.cc:457:13: error: no matching function for call to 'copyFont'
            copyFont(obj->dictGetKey(i), &fontRef);
            ^~~~~~~~
pdftexdir/pdftoepdf.cc:385:13: note: candidate function not viable: 1st argument ('const char *') would lose const qualifier
static void copyFont(char *tag, Object * fontRef)
            ^
pdftexdir/pdftoepdf.cc:980:27: error: call to deleted member function 'dictAdd'
                groupDict.dictAdd(copyString(dic1.getKey(i)),
                ~~~~~~~~~~^~~~~~~
/opt/local/include/poppler/Object.h:276:8: note: candidate function has been explicitly deleted
  void dictAdd(char *key, Object &&val) = delete;
       ^
/opt/local/include/poppler/Object.h:359:21: note: candidate function
inline void Object::dictAdd(const char *key, Object &&val)
                    ^
pdftexdir/pdftoepdf.cc:1004:25: error: assigning to 'char *' from incompatible type 'const char *'
            key = obj1->dictGetKey(i);
                  ~~~~~~^~~~~~~~~~~~~
4 errors generated.

Assigning to poppler first since this appears to have broken a dependency.

[squizzgitmon]

I'm getting the same. I unuistalled texlive and tried again. Now can't install it, and I need to use it today!

[dbevans (David B. Evans)]

See: ​https://github.com/macports/macports-ports/pull/2651

[dbevans (David B. Evans)]

In ecfb5948bf1cf384a2e03d963423728b83e21ab6/macports-ports (master):

texlive-bin: rebuild with patch for poppler 0.69.0

This builds for me but I'll leave it to the maintainer to test/verify.

Closes: #57162.