Opened 2 years ago

Closed 2 years ago

#57247 closed defect (fixed)

http-parser: Please use the right compiler and -arch flags

Reported by: ryandesign (Ryan Schmidt) Owned by: Lord-Kamina (Gregorio Litenstein)
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc:
Port: http-parser

Change History (4)

comment:1 Changed 2 years ago by ryandesign (Ryan Schmidt)

And if possible add a universal variant.

comment:2 Changed 2 years ago by ryandesign (Ryan Schmidt)

Gregorio responded on GitHub:

Will take care of it as soon as I can. Also will try to see if I can use the regular configure; there must be a reason I did it like this but honestly I can't remember.

Looks like this software does not have a configure script.

Could you please point me to a reference for the best way to take care of the architectures?

Autotools configure scripts behave in a predictable standardized way, so MacPorts can automatically tell them how to use the right compiler and arch flags. But when autotools are not used, and the developer writes a custom Makefile, you have to read the Makefile and figure out how to pass this information to the Makefile, since it's going to be different depending on how the developer happened to write it.

Since I'm already looking at the Makefile now, I'll send a PR for the needed changes shortly.

comment:4 Changed 2 years ago by ryandesign (Ryan Schmidt)

Resolution: fixed
Status: assignedclosed

In 978d6787fff82f71a0289188ead377d389bb8734/macports-ports (master):

http-parser: Use compiler, arch, universal

Use the right compiler and -arch flags and add a universal variant.

Closes #57247

Only build the library in the build phase; don't run the tests.

Enable the test phase so that the tests can be run if desired.

Fix the Makefile:

  • Don't use -Werror
  • Don't rebuild the library unless that's needed
  • Use -dynamiclib instead of -shared on macOS
Note: See TracTickets for help on using tickets.