Opened 6 years ago

Closed 6 years ago

#57275 closed defect (fixed)

nco uses -I/usr/include/malloc

Reported by: ryandesign (Ryan Carsten Schmidt) Owned by: tenomoto (Takeshi Enomoto)
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc:
Port: nco

Description

The nco portfile adds -I/usr/include/malloc to CPPFLAGS. It has done this ever since [227c2ac3a4309b872eade0c8adad9e1b2f829b7d/macports-ports], though the commit message doesn't say why it was added. The only file in /usr/include/malloc on prior systems was malloc.h, so I presume the project is—or was back in 2007—using #include <malloc.h> somewhere.

I have not tried to build this port on Mojave yet but this can't work on Mojave because it doesn't have a /usr/include directory. It could be that the project no longer includes malloc.h. If so, the -I flag can just be removed. If the project still does include malloc.h, the include should be changed to stdlib.h; this should work on any version of macOS.

Change History (1)

comment:1 Changed 6 years ago by tenomoto (Takeshi Enomoto)

Resolution: fixed
Status: assignedclosed

In 0cffc58f2a3c958d44f4b13d0209fd9e1359a656/macports-ports (master):

nco: enable build on Mojave. add openmp variant

Closes: #57275

Note: See TracTickets for help on using tickets.